Bug 210147 - Delete ICs should not cache dictionaries
Summary: Delete ICs should not cache dictionaries
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-07 13:28 PDT by Saam Barati
Modified: 2020-04-07 16:11 PDT (History)
13 users (show)

See Also:

Attachments
patch (3.52 KB, patch)
2020-04-07 13:33 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (3.68 KB, patch)
2020-04-07 13:38 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2020-04-07 13:28:24 PDT 
...
Comment 1 Saam Barati 2020-04-07 13:28:53 PDT 
<rdar://problem/61382405>
Comment 2 Saam Barati 2020-04-07 13:33:02 PDT 
Created attachment 395730 [details]
patch
Comment 3 Saam Barati 2020-04-07 13:34:18 PDT 
Comment on attachment 395730 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395730&action=review

> Source/JavaScriptCore/jit/Repatch.cpp:760
> +            jsCast<JSObject*>(baseValue)->flattenDictionaryObject(vm);

oops, I need to check hasBeenFlattenedBefore
Comment 4 Saam Barati 2020-04-07 13:38:15 PDT 
Created attachment 395732 [details]
patch
Comment 5 Tadeu Zagallo 2020-04-07 14:50:13 PDT 
Comment on attachment 395732 [details]
patch

r=me
Comment 6 EWS 2020-04-07 16:11:26 PDT 
Committed r259681: <https://trac.webkit.org/changeset/259681>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395732 [details].