WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
210137
Web Automation: Automation.inspectBrowsingContext should bring Web Inspector to front automatically
https://bugs.webkit.org/show_bug.cgi?id=210137
Summary
Web Automation: Automation.inspectBrowsingContext should bring Web Inspector ...
Blaze Burg
Reported
2020-04-07 11:50:29 PDT
.
Attachments
Patch
(1.90 KB, patch)
2020-04-07 11:56 PDT
,
Blaze Burg
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Blaze Burg
Comment 1
2020-04-07 11:56:45 PDT
Created
attachment 395719
[details]
Patch
Joseph Pecoraro
Comment 2
2020-04-07 12:46:20 PDT
Comment on
attachment 395719
[details]
Patch rs=me
Devin Rousso
Comment 3
2020-04-07 12:48:28 PDT
Comment on
attachment 395719
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=395719&action=review
r=me
> Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm:59 > if (page->inspector()) {
NIT: why not save this result so you don't have to call it again? ``` if (auto* inspector = page->inspector()) inspector->show(); ```
EWS
Comment 4
2020-04-07 13:07:52 PDT
Committed
r259665
: <
https://trac.webkit.org/changeset/259665
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 395719
[details]
.
Radar WebKit Bug Importer
Comment 5
2020-04-07 13:08:13 PDT
<
rdar://problem/61406816
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug