Bug 210126 - [JSC] ScopedArgumentsTable should handle OOM in tolerant manner
Summary: [JSC] ScopedArgumentsTable should handle OOM in tolerant manner
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-07 09:50 PDT by Yusuke Suzuki
Modified: 2020-04-07 11:05 PDT (History)
7 users (show)

See Also:

Attachments
Patch (12.36 KB, patch)
2020-04-07 09:53 PDT, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-04-07 09:50:12 PDT 
[JSC] ScopedArgumentsTable should handle OOM in tolerant manner
Comment 1 Yusuke Suzuki 2020-04-07 09:53:26 PDT 
Created attachment 395690 [details]
Patch
Comment 2 Yusuke Suzuki 2020-04-07 09:54:03 PDT 
<rdar://problem/61385114>
Comment 3 Mark Lam 2020-04-07 10:02:41 PDT 
Comment on attachment 395690 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395690&action=review

r=me

> Source/JavaScriptCore/runtime/ScopedArguments.cpp:146
> +    auto scope = DECLARE_THROW_SCOPE(vm);

You’re adding a ThrowScope.  Make sure to run JSC stress tests with a debug build (use --force-opt=O3 to run faster) to make sure there’s no new missing exception check failures.
Comment 4 Yusuke Suzuki 2020-04-07 10:04:00 PDT 
Comment on attachment 395690 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395690&action=review

>> Source/JavaScriptCore/runtime/ScopedArguments.cpp:146
>> +    auto scope = DECLARE_THROW_SCOPE(vm);
> 
> You’re adding a ThrowScope.  Make sure to run JSC stress tests with a debug build (use --force-opt=O3 to run faster) to make sure there’s no new missing exception check failures.

I think this is OK since caller of unmapArgument has proper exception checks.
Comment 5 Yusuke Suzuki 2020-04-07 11:05:05 PDT 
Committed r259646: <https://trac.webkit.org/changeset/259646>