Bug 210124 – Return app-bound sessions for instances where WKAppBoundDomains is empty

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Kate Cheney]

We can use the mechanisms implemented in bug 210074 to signal whether the WKAppBoundDomains list is empty, and return an app-bound network session by default.

[Kate Cheney]

Created attachment 395693 [details]
Patch

[Kate Cheney]

Created attachment 395705 [details]
Patch

[Kate Cheney]

Created attachment 395709 [details]
Patch

[Brent Fulgham]

Comment on attachment 395709 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395709&action=review

> Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:412
> +        RunLoop::main().dispatch([isInAppBrowserPrivacyEnabled, forceReinitialization , domains = retainPtr(domains)] {

Nit: Extra space after 'forceReinitialization'

[Kate Cheney]

Created attachment 395712 [details]
Patch for landing

[Kate Cheney]

<rdar://problem/61276630>

[EWS]

Committed r259655: <https://trac.webkit.org/changeset/259655>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395712 [details].

[Ryan Haddad]

Seeing the following on iOS debug tests after this change:
ASSERTION FAILED: hasInitializedAppBoundDomains
/Volumes/Data/slave/ios-simulator-13-debug/build/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm(445) : auto WebKit::WebsiteDataStore::ensureAppBoundDomains(CompletionHandler<void (const HashSet<WebCore::RegistrableDomain> &)> &&)::(anonymous class)::operator()()::(anonymous class)::operator()()
https://build.webkit.org/builders/Apple%20iOS%2013%20Simulator%20Debug%20WK2%20(Tests)/builds/3010

This manifests as timeouts on release bots, so EWS is impacted by test retries.

[Ryan Haddad]

Reverted r259655 for reason:

Caused assertion failures and timeouts on iOS bots

Committed r259675: <https://trac.webkit.org/changeset/259675>

[Kate Cheney]

Created attachment 395757 [details]
Patch

[Kate Cheney]

(In reply to katherine_cheney from comment #10)
> Created attachment 395757 [details]
> Patch

Letting EWS run.

[Kate Cheney]

Created attachment 395759 [details]
Patch

[Kate Cheney]

Created attachment 395817 [details]
Patch

[Kate Cheney]

(In reply to katherine_cheney from comment #13)
> Created attachment 395817 [details]
> Patch

iOS API and wk bots are green.

[Kate Cheney]

Created attachment 395832 [details]
Patch for landing

[EWS]

Committed r259731: <https://trac.webkit.org/changeset/259731>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395832 [details].