Bug 210121 - AX: Change ATK mapping of the ARIA alert and alertdialog roles
Summary: AX: Change ATK mapping of the ARIA alert and alertdialog roles
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All Linux
: P2 Normal
Assignee: Joanmarie Diggs (irc: joanie)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-07 09:35 PDT by Joanmarie Diggs (irc: joanie)
Modified: 2020-04-07 14:14 PDT (History)
8 users (show)

See Also:


Attachments
Patch (7.94 KB, patch)
2020-04-07 11:11 PDT, Joanmarie Diggs (irc: joanie)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joanmarie Diggs (irc: joanie) 2020-04-07 09:35:11 PDT
In ARIA, an alertdialog is a type of dialog; an alert is not a type of dialog but rather a live region.
    
In ATK an alert is a type of dialog which should be used for things like warning dialogs. Thus this platform role is well suited for the ARIA alertdialog role, but ill suited for the ARIA alert role.

As a result of the above, the Core-AAM specification has been updated:

    * alertdialog: ATK_ROLE_ALERT rather than ATK_ROLE_DIALOG
    * alert: ATK_ROLE_NOTIFICATION rather than ATK_ROLE_ALERT
    
See https://w3c.github.io/core-aam/#mapping_role_table
Comment 1 Radar WebKit Bug Importer 2020-04-07 09:35:22 PDT
<rdar://problem/61396168>
Comment 2 Joanmarie Diggs (irc: joanie) 2020-04-07 11:11:08 PDT
Created attachment 395711 [details]
Patch
Comment 3 Joanmarie Diggs (irc: joanie) 2020-04-07 13:09:22 PDT
Comment on attachment 395711 [details]
Patch

Chris: When you have a spare moment, a review would be appreciated. Thanks!
Comment 4 EWS 2020-04-07 14:14:21 PDT
Committed r259671: <https://trac.webkit.org/changeset/259671>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395711 [details].