Bug 210110 - [GTK] CMake find module for GTK4
Summary: [GTK] CMake find module for GTK4
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords:
Depends on:
Blocks: GTK4 210154
  Show dependency tree / graph
 
Reported: 2020-04-07 07:24 PDT by Adrian Perez
Modified: 2020-04-07 14:14 PDT (History)
12 users (show)

See Also:

Attachments
Patch (22.39 KB, patch)
2020-04-07 07:40 PDT, Adrian Perez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2020-04-07 07:24:18 PDT 
We will need to be able to make CMake aware of GTK4, while still
keeping the possibility to use GTK3. We can go about this in two
possible ways:

 - Add a new FindGTK4.cmake file
 - Modify FindGTK3.cmake to support both versions and rename it
   to FindGTK.cmake.

While at it, we could make the find module provide an imported
target to simplify the build definitions and make the build more
robust.
Comment 1 Adrian Perez 2020-04-07 07:40:37 PDT 
Created attachment 395678 [details]
Patch
Comment 2 EWS 2020-04-07 09:25:21 PDT 
Committed r259641: <https://trac.webkit.org/changeset/259641>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395678 [details].