Bug 210107 – Bump priority of LibWebRTCAudioModule thread

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Bump priority of LibWebRTCAudioModule thread.
This thread is responsible to get audio samples and push them to audio renderers.

[youenn fablet]

Created attachment 395676 [details]
Patch

[youenn fablet]

Created attachment 395677 [details]
Patch

[youenn fablet]

Created attachment 395951 [details]
Patch

[Eric Carlson]

Comment on attachment 395951 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395951&action=review

> Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.cpp:73
>  void LibWebRTCAudioModule::StartPlayoutOnAudioThread()

This name seems wrong now that it is essentially a one-shot. Maybe something like `PullDataOnAudioThread`, or fold maybe the logic into PollFromSource instead?

> Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.cpp:102
> +        char data[(LibWebRTCAudioFormat::sampleByteSize * channels * LibWebRTCAudioFormat::chunkSampleCount)];

Now that the chunk size is constant (for a given channel count), maybe we should use a member variable that is (re)allocated when the number of channels changes?

[youenn fablet]

Created attachment 395960 [details]
Patch for landing

[EWS]

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

[youenn fablet]

Created attachment 396053 [details]
Patch for landing

[EWS]

Committed r259853: <https://trac.webkit.org/changeset/259853>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396053 [details].

[Radar WebKit Bug Importer]

<rdar://problem/61575334>