Bug 210099 - TextManipulationController fails to replace a paragraph that ends with a br
Summary: TextManipulationController fails to replace a paragraph that ends with a br
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-07 00:59 PDT by Ryosuke Niwa
Modified: 2020-04-07 11:10 PDT (History)
7 users (show)

See Also:


Attachments
Fixes the bug (9.36 KB, patch)
2020-04-07 01:03 PDT, Ryosuke Niwa
wenson_hsieh: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2020-04-07 00:59:29 PDT
Replacing a paragraph content fails with ContentChanged if the paragraph ends with a br.
Comment 1 Radar WebKit Bug Importer 2020-04-07 01:00:21 PDT
<rdar://problem/61381732>
Comment 2 Ryosuke Niwa 2020-04-07 01:03:11 PDT
Created attachment 395658 [details]
Fixes the bug
Comment 3 Louie Livon-Bemel 2020-04-07 10:45:57 PDT
(In reply to Ryosuke Niwa from comment #2)
> Created attachment 395658 [details]
> Fixes the bug

Typo: in `CompleteTextManipulationReplaceParagraphssSeparatedByWrappedBR`, 'Paragraphss' should be 'Paragraphs'.
Comment 4 Wenson Hsieh 2020-04-07 10:55:46 PDT
Comment on attachment 395658 [details]
Fixes the bug

r=me (with Louie’s comment above)
Comment 5 Ryosuke Niwa 2020-04-07 11:10:11 PDT
Committed r259647: <https://trac.webkit.org/changeset/259647>