Bug 210095 - [Async overflow scroll] Horizontal scrolls can trigger unwanted back swipes
Summary: [Async overflow scroll] Horizontal scrolls can trigger unwanted back swipes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
: 211049 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-04-06 21:43 PDT by Simon Fraser (smfr)
Modified: 2020-04-29 07:46 PDT (History)
11 users (show)

See Also:

Attachments
Test (1.25 KB, text/html)
2020-04-06 21:43 PDT, Simon Fraser (smfr) 		no flags Details
Patch (37.94 KB, patch)
2020-04-08 14:51 PDT, Simon Fraser (smfr) 		thorton: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-04-06 21:43:59 PDT 
Created attachment 395652 [details]
Test

With async overflow scroll, scrolls inside a horizontally-scrollable container can end up doing a history swipe instead of a scroll.
Comment 1 Radar WebKit Bug Importer 2020-04-06 21:44:13 PDT 
<rdar://problem/61376245>
Comment 2 Simon Fraser (smfr) 2020-04-08 14:51:08 PDT 
Created attachment 395872 [details]
Patch
Comment 3 Tim Horton 2020-04-08 15:22:27 PDT 
Comment on attachment 395872 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395872&action=review

> Source/WebCore/platform/cocoa/ScrollController.mm:107
> +        // FIXME: Trying to decide if a gesture is horizontal or vertical at the "began" phase is very error-prone.

This likely wants something more like a generalized VGC::PendingSwipeTracker
Comment 4 EWS 2020-04-09 05:23:40 PDT 
Found 2 new test failures: http/tests/adClickAttribution/anchor-tag-attributes-validation.html, http/tests/security/anchor-download-block-crossorigin.html
Comment 5 Simon Fraser (smfr) 2020-04-09 09:34:52 PDT 
https://trac.webkit.org/changeset/259805/webkit
Comment 6 Simon Fraser (smfr) 2020-04-29 07:46:13 PDT 
*** Bug 211049 has been marked as a duplicate of this bug. ***