Bug 210090 – Initialization of modal nodes should happen lazily, not in the AXObjectCache constructor.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andres Gonzalez]

Initialization of modal nodes should happen lazily, not in the AXObjectCache constructor.

[Andres Gonzalez]

Created attachment 395646 [details]
Patch

[chris fleizach]

Comment on attachment 395646 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395646&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:305
> +        m_currentModalNode = currentModalNode();

should currentModalNode() set m_currentModalNode? I feel like that way it can cache the value as needed and return the variable appropriately from one place of access

> Source/WebCore/accessibility/AXObjectCache.cpp:318
> +    m_currentModalNode = currentModalNode();

then here can just return currentModalNode()

[Andres Gonzalez]

Created attachment 395648 [details]
Patch

[Andres Gonzalez]

(In reply to chris fleizach from comment #2)
> Comment on attachment 395646 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=395646&action=review
> 
> > Source/WebCore/accessibility/AXObjectCache.cpp:305
> > +        m_currentModalNode = currentModalNode();
> 
> should currentModalNode() set m_currentModalNode? I feel like that way it
> can cache the value as needed and return the variable appropriately from one
> place of access

Done. 
> 
> > Source/WebCore/accessibility/AXObjectCache.cpp:318
> > +    m_currentModalNode = currentModalNode();
> 
> then here can just return currentModalNode()

Done.

[EWS]

Committed r259633: <https://trac.webkit.org/changeset/259633>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395648 [details].

[Radar WebKit Bug Importer]

<rdar://problem/61388295>