Bug 210090 - Initialization of modal nodes should happen lazily, not in the AXObjectCache constructor.
Summary: Initialization of modal nodes should happen lazily, not in the AXObjectCache ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-06 19:27 PDT by Andres Gonzalez
Modified: 2020-04-07 04:53 PDT (History)
9 users (show)

See Also:

Attachments
Patch (7.50 KB, patch)
2020-04-06 19:45 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (7.54 KB, patch)
2020-04-06 20:38 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2020-04-06 19:27:16 PDT 
Initialization of modal nodes should happen lazily, not in the AXObjectCache constructor.
Comment 1 Andres Gonzalez 2020-04-06 19:45:26 PDT 
Created attachment 395646 [details]
Patch
Comment 2 chris fleizach 2020-04-06 19:57:32 PDT 
Comment on attachment 395646 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395646&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:305
> +        m_currentModalNode = currentModalNode();

should currentModalNode() set m_currentModalNode? I feel like that way it can cache the value as needed and return the variable appropriately from one place of access

> Source/WebCore/accessibility/AXObjectCache.cpp:318
> +    m_currentModalNode = currentModalNode();

then here can just return currentModalNode()
Comment 3 Andres Gonzalez 2020-04-06 20:38:23 PDT 
Created attachment 395648 [details]
Patch
Comment 4 Andres Gonzalez 2020-04-06 20:41:23 PDT 
(In reply to chris fleizach from comment #2)
> Comment on attachment 395646 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=395646&action=review
> 
> > Source/WebCore/accessibility/AXObjectCache.cpp:305
> > +        m_currentModalNode = currentModalNode();
> 
> should currentModalNode() set m_currentModalNode? I feel like that way it
> can cache the value as needed and return the variable appropriately from one
> place of access

Done. 
> 
> > Source/WebCore/accessibility/AXObjectCache.cpp:318
> > +    m_currentModalNode = currentModalNode();
> 
> then here can just return currentModalNode()

Done.
Comment 5 EWS 2020-04-07 04:52:30 PDT 
Committed r259633: <https://trac.webkit.org/changeset/259633>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395648 [details].
Comment 6 Radar WebKit Bug Importer 2020-04-07 04:53:18 PDT 
<rdar://problem/61388295>