WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
210084
Add release asserts to KeyframeEffectStack::ensureEffectsAreSorted()
https://bugs.webkit.org/show_bug.cgi?id=210084
Summary
Add release asserts to KeyframeEffectStack::ensureEffectsAreSorted()
Doug Kelly
Reported
2020-04-06 17:26:13 PDT
KeyframeEffectStack::ensureEffectsAreSorted() has several areas where either null pointers or an unexpected condition could cause a crash that's further away from the actual failure. To make these issues easier to detect and troubleshoot, add several RELEASE_ASSERTs to test these cases explicitly. <
rdar://problem/61359275
>
Attachments
Patch
(3.25 KB, patch)
2020-04-06 17:30 PDT
,
Doug Kelly
no flags
Details
Formatted Diff
Diff
Patch
(3.26 KB, patch)
2020-04-06 20:23 PDT
,
Doug Kelly
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Doug Kelly
Comment 1
2020-04-06 17:30:36 PDT
Created
attachment 395638
[details]
Patch
Doug Kelly
Comment 2
2020-04-06 20:23:48 PDT
Created
attachment 395647
[details]
Patch
EWS
Comment 3
2020-04-07 01:26:05 PDT
Committed
r259630
: <
https://trac.webkit.org/changeset/259630
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 395647
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug