Bug 210084 - Add release asserts to KeyframeEffectStack::ensureEffectsAreSorted()
Summary: Add release asserts to KeyframeEffectStack::ensureEffectsAreSorted()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Local Build
Hardware: Mac macOS 10.15
: P2 Normal
Assignee: Doug Kelly
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-06 17:26 PDT by Doug Kelly
Modified: 2020-04-07 01:26 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.25 KB, patch)
2020-04-06 17:30 PDT, Doug Kelly
no flags Details | Formatted Diff | Diff
Patch (3.26 KB, patch)
2020-04-06 20:23 PDT, Doug Kelly
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Doug Kelly 2020-04-06 17:26:13 PDT
KeyframeEffectStack::ensureEffectsAreSorted() has several areas where either null pointers or an unexpected condition could cause a crash that's further away from the actual failure.  To make these issues easier to detect and troubleshoot, add several RELEASE_ASSERTs to test these cases explicitly.

<rdar://problem/61359275>
Comment 1 Doug Kelly 2020-04-06 17:30:36 PDT
Created attachment 395638 [details]
Patch
Comment 2 Doug Kelly 2020-04-06 20:23:48 PDT
Created attachment 395647 [details]
Patch
Comment 3 EWS 2020-04-07 01:26:05 PDT
Committed r259630: <https://trac.webkit.org/changeset/259630>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395647 [details].