Bug 21008 - getting pixels by index from CanvasPixelArray is unnecessarily slow
Summary: getting pixels by index from CanvasPixelArray is unnecessarily slow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-22 15:01 PDT by Darin Adler
Modified: 2008-09-23 03:04 PDT (History)
1 user (show)

See Also:

Attachments
patch, already reviewed (for Oliver) (15.04 KB, patch)
2008-09-22 15:11 PDT, Darin Adler 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2008-09-22 15:01:56 PDT 
Oliver noticed that when we index into a CanvasPixelArray, we convert the index to a string and put it into the identifier table each time. The identifier is then ignored by the CanvasPixelArray::indexGetter function. This extra work is bad!
Comment 1 Darin Adler 2008-09-22 15:11:24 PDT 
Created attachment 23674 [details]
patch, already reviewed (for Oliver)
Comment 2 Oliver Hunt 2008-09-23 00:41:55 PDT 
Comment on attachment 23674 [details]
patch, already reviewed (for Oliver)

Removed the toStrictUInt32 as that broke compat with ffx3
Comment 3 Oliver Hunt 2008-09-23 00:42:13 PDT 
Landed r36801
Comment 4 Oliver Hunt 2008-09-23 03:04:31 PDT 
Whoops, missed afile

	A	WebCore/bindings/js/JSCanvasPixelArrayCustom.h
Committed r36803