Bug 210078 – REGRESSION: 68000 JSC tests failing

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Truitt Savell]

recently 68000 JSC tests began failing. I do not have a solid regression point because the build stopped working on this queue today for a time. 

Build Queue:
https://build.webkit.org/builders/Apple-Catalina-Debug-JSC-Tests?numbuilds=50

Build:
https://build.webkit.org/builders/Apple-Catalina-Debug-JSC-Tests/builds/637

Stdio:
https://build.webkit.org/builders/Apple-Catalina-Debug-JSC-Tests/builds/637/steps/jscore-test/logs/stdio

[Radar WebKit Bug Importer]

<rdar://problem/61364513>

[Mark Lam]

This failure is caused by https://trac.webkit.org/r259587 for https://bugs.webkit.org/show_bug.cgi?id=187526.

[Mark Lam]

Created attachment 395631 [details]
proposed patch.

[Yusuke Suzuki]

Comment on attachment 395631 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=395631&action=review

r=me

> Source/JavaScriptCore/jsc.cpp:603
> +        RELEASE_ASSERT(!catchScope.exception());

how about using EXCEPTION_ASSERT?

[Mark Lam]

Thanks for the review.

(In reply to Yusuke Suzuki from comment #4)
> > Source/JavaScriptCore/jsc.cpp:603
> > +        RELEASE_ASSERT(!catchScope.exception());
> 
> how about using EXCEPTION_ASSERT?

Talked to Yusuke offline.  Will use scope.releaseAssertNoException() instead.

[Mark Lam]

Landed in r259614: <http://trac.webkit.org/r259614>.