Bug 210078 - REGRESSION: 68000 JSC tests failing
Summary: REGRESSION: 68000 JSC tests failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-06 16:14 PDT by Truitt Savell
Modified: 2020-04-06 17:13 PDT (History)
9 users (show)

See Also:


Attachments
proposed patch. (1.80 KB, patch)
2020-04-06 16:44 PDT, Mark Lam
ysuzuki: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Truitt Savell 2020-04-06 16:14:12 PDT
recently 68000 JSC tests began failing. I do not have a solid regression point because the build stopped working on this queue today for a time. 

Build Queue:
https://build.webkit.org/builders/Apple-Catalina-Debug-JSC-Tests?numbuilds=50

Build:
https://build.webkit.org/builders/Apple-Catalina-Debug-JSC-Tests/builds/637

Stdio:
https://build.webkit.org/builders/Apple-Catalina-Debug-JSC-Tests/builds/637/steps/jscore-test/logs/stdio
Comment 1 Radar WebKit Bug Importer 2020-04-06 16:15:13 PDT
<rdar://problem/61364513>
Comment 2 Mark Lam 2020-04-06 16:36:53 PDT
This failure is caused by https://trac.webkit.org/r259587 for https://bugs.webkit.org/show_bug.cgi?id=187526.
Comment 3 Mark Lam 2020-04-06 16:44:09 PDT
Created attachment 395631 [details]
proposed patch.
Comment 4 Yusuke Suzuki 2020-04-06 16:45:51 PDT
Comment on attachment 395631 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=395631&action=review

r=me

> Source/JavaScriptCore/jsc.cpp:603
> +        RELEASE_ASSERT(!catchScope.exception());

how about using EXCEPTION_ASSERT?
Comment 5 Mark Lam 2020-04-06 16:52:31 PDT
Thanks for the review.

(In reply to Yusuke Suzuki from comment #4)
> > Source/JavaScriptCore/jsc.cpp:603
> > +        RELEASE_ASSERT(!catchScope.exception());
> 
> how about using EXCEPTION_ASSERT?

Talked to Yusuke offline.  Will use scope.releaseAssertNoException() instead.
Comment 6 Mark Lam 2020-04-06 17:13:35 PDT
Landed in r259614: <http://trac.webkit.org/r259614>.