WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
210075
Remove unneeded UIKitSPI declarations
https://bugs.webkit.org/show_bug.cgi?id=210075
Summary
Remove unneeded UIKitSPI declarations
Megan Gardner
Reported
2020-04-06 14:48:47 PDT
Remove unneded UIKitSPI declarations
Attachments
Patch
(5.34 KB, patch)
2020-04-06 14:59 PDT
,
Megan Gardner
no flags
Details
Formatted Diff
Diff
Patch
(7.13 KB, patch)
2021-08-17 16:03 PDT
,
Megan Gardner
no flags
Details
Formatted Diff
Diff
Patch
(7.14 KB, patch)
2021-08-17 16:35 PDT
,
Megan Gardner
no flags
Details
Formatted Diff
Diff
Patch for landing
(7.13 KB, patch)
2021-08-18 13:20 PDT
,
Megan Gardner
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Megan Gardner
Comment 1
2020-04-06 14:59:14 PDT
Created
attachment 395622
[details]
Patch
Wenson Hsieh
Comment 2
2020-04-06 15:10:13 PDT
Comment on
attachment 395622
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=395622&action=review
> Source/WebKit/ChangeLog:3 > + Remove uneeded UIKitSPI declarations
Nit - uneeded => unneeded
> Source/WebKit/ChangeLog:8 > + Modifier flags are now public, and we weren't using __paused.
Nit - extra _ before _paused
Megan Gardner
Comment 3
2021-08-17 16:03:14 PDT
Created
attachment 435721
[details]
Patch
Wenson Hsieh
Comment 4
2021-08-17 16:07:12 PDT
Comment on
attachment 435721
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=435721&action=review
r=mews
> Source/WTF/ChangeLog:8 > + Remove unneded feature define.
Nit - unneded => unneeded
Megan Gardner
Comment 5
2021-08-17 16:35:24 PDT
Created
attachment 435726
[details]
Patch
Megan Gardner
Comment 6
2021-08-18 13:20:02 PDT
Created
attachment 435792
[details]
Patch for landing
EWS
Comment 7
2021-08-18 14:17:33 PDT
Committed
r281210
(
240649@main
): <
https://commits.webkit.org/240649@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 435792
[details]
.
Radar WebKit Bug Importer
Comment 8
2021-08-18 14:18:17 PDT
<
rdar://problem/82093990
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug