Bug 210075 - Remove unneeded UIKitSPI declarations
Summary: Remove unneeded UIKitSPI declarations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-06 14:48 PDT by Megan Gardner
Modified: 2021-08-18 14:18 PDT (History)
7 users (show)

See Also:


Attachments
Patch (5.34 KB, patch)
2020-04-06 14:59 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch (7.13 KB, patch)
2021-08-17 16:03 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch (7.14 KB, patch)
2021-08-17 16:35 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch for landing (7.13 KB, patch)
2021-08-18 13:20 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2020-04-06 14:48:47 PDT
Remove unneded UIKitSPI declarations
Comment 1 Megan Gardner 2020-04-06 14:59:14 PDT
Created attachment 395622 [details]
Patch
Comment 2 Wenson Hsieh 2020-04-06 15:10:13 PDT
Comment on attachment 395622 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395622&action=review

> Source/WebKit/ChangeLog:3
> +        Remove uneeded UIKitSPI declarations

Nit - uneeded => unneeded

> Source/WebKit/ChangeLog:8
> +        Modifier flags are now public, and we weren't using __paused. 

Nit - extra _ before _paused
Comment 3 Megan Gardner 2021-08-17 16:03:14 PDT
Created attachment 435721 [details]
Patch
Comment 4 Wenson Hsieh 2021-08-17 16:07:12 PDT
Comment on attachment 435721 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435721&action=review

r=mews

> Source/WTF/ChangeLog:8
> +        Remove unneded feature define.

Nit - unneded => unneeded
Comment 5 Megan Gardner 2021-08-17 16:35:24 PDT
Created attachment 435726 [details]
Patch
Comment 6 Megan Gardner 2021-08-18 13:20:02 PDT
Created attachment 435792 [details]
Patch for landing
Comment 7 EWS 2021-08-18 14:17:33 PDT
Committed r281210 (240649@main): <https://commits.webkit.org/240649@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435792 [details].
Comment 8 Radar WebKit Bug Importer 2021-08-18 14:18:17 PDT
<rdar://problem/82093990>