Bug 210059 - [CMake] Use WEBKIT_EXECUTABLE in DumpRenderTree
Summary: [CMake] Use WEBKIT_EXECUTABLE in DumpRenderTree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-06 11:08 PDT by Don Olmstead
Modified: 2020-04-06 17:58 PDT (History)
9 users (show)

See Also:

Attachments
Patch (9.77 KB, patch)
2020-04-06 11:18 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (9.78 KB, patch)
2020-04-06 12:03 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (10.02 KB, patch)
2020-04-06 13:20 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (10.37 KB, patch)
2020-04-06 15:38 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (10.46 KB, patch)
2020-04-06 15:46 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2020-04-06 11:08:25 PDT 
WEBKIT_EXECUTABLE(DumpRenderTree)
Comment 1 Don Olmstead 2020-04-06 11:18:39 PDT Comment hidden (obsolete)
Comment 2 Don Olmstead 2020-04-06 12:03:13 PDT Comment hidden (obsolete)
Comment 3 Don Olmstead 2020-04-06 13:20:35 PDT Comment hidden (obsolete)
Comment 4 Don Olmstead 2020-04-06 15:38:30 PDT Comment hidden (obsolete)
Comment 5 Don Olmstead 2020-04-06 15:46:40 PDT 
Created attachment 395625 [details]
Patch
Comment 6 Fujii Hironori 2020-04-06 17:44:59 PDT 
Comment on attachment 395625 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395625&action=review

> Tools/DumpRenderTree/CMakeLists.txt:45
> +    ${PAL_FRAMEWORK_HEADERS_DIR}

Do you need to add PAL_FRAMEWORK_HEADERS_DIR? Why don't you use WebKit::PAL?
Comment 7 Don Olmstead 2020-04-06 17:54:04 PDT 
(In reply to Fujii Hironori from comment #6)
> Comment on attachment 395625 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=395625&action=review
> 
> > Tools/DumpRenderTree/CMakeLists.txt:45
> > +    ${PAL_FRAMEWORK_HEADERS_DIR}
> 
> Do you need to add PAL_FRAMEWORK_HEADERS_DIR? Why don't you use WebKit::PAL?

I think we need a macro that handles the fact that every WEBKIT_FRAMEWORK could be SHARED/STATIC/OBJECT and propagate interfaces correctly. That's a temporary kludge around it.
Comment 8 EWS 2020-04-06 17:58:36 PDT 
Committed r259617: <https://trac.webkit.org/changeset/259617>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395625 [details].