ImageDiff is crashing on some iOS Asan bots. This is one of the binaries that probably shouldn't be built with Asan in the first place, since it is not built with the target SDK.
<rdar://problem/61234753>
Created attachment 395584 [details] Patch
Comment on attachment 395584 [details] Patch r=me, although for the record, I always liked the idea of running tools with ASan because it would catch moar boogs.
Comment on attachment 395584 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395584&action=review > Tools/ImageDiff/cg/Configurations/ImageDiff.xcconfig:1 > +// Copyright (C) 2009, 2020 Apple Inc. All rights reserved. Nit: Should be "2009-2020".
(In reply to David Kilzer (:ddkilzer) from comment #3) > Comment on attachment 395584 [details] > Patch > > r=me, although for the record, I always liked the idea of running tools with > ASan because it would catch moar boogs. For WebKitTetsRunner, TestWebKitAPI and friends, I totally agree. ImageDiff is a special situation, though, because it's always built with the Mac SDK, even when other projects are built with a different SDK (in this case, iOS was the SDK giving us issues). (just responding so we have a record of why I made this change to this particular tool in case someone wants to un-do this in the future :) )
Created attachment 395595 [details] Patch for landing
Found 1 new test failure: inspector/canvas/shaderProgram-add-remove-webgpu.html
Comment on attachment 395595 [details] Patch for landing Commit queue is clearly wrong, this change could not have broken a test.
Committed r259616: <https://trac.webkit.org/changeset/259616> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395595 [details].