Bug 210055 - [JSC] Since ArrayBufferViewWatchpointAdaptor::add can fire watchpoints, DFG::Plan should check validity of CodeBlock after executing reallyAdd
Summary: [JSC] Since ArrayBufferViewWatchpointAdaptor::add can fire watchpoints, DFG::...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-06 10:17 PDT by Yusuke Suzuki
Modified: 2020-04-06 10:36 PDT (History)
7 users (show)

See Also:


Attachments
Patch (3.63 KB, patch)
2020-04-06 10:19 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (3.63 KB, patch)
2020-04-06 10:22 PDT, Yusuke Suzuki
keith_miller: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-04-06 10:17:06 PDT
[JSC] Since ArrayBufferViewWatchpointAdaptor::add can fire watchpoints, DFG::Plan should check validity of CodeBlock after executing reallyAdd
Comment 1 Yusuke Suzuki 2020-04-06 10:19:26 PDT
Created attachment 395582 [details]
Patch
Comment 2 Yusuke Suzuki 2020-04-06 10:19:29 PDT
<rdar://problem/61331962>
Comment 3 Yusuke Suzuki 2020-04-06 10:22:24 PDT
Created attachment 395583 [details]
Patch
Comment 4 Keith Miller 2020-04-06 10:32:10 PDT
Comment on attachment 395583 [details]
Patch

r=me.
Comment 5 Yusuke Suzuki 2020-04-06 10:36:02 PDT
Committed r259576: <https://trac.webkit.org/changeset/259576>