Bug 210042 – Make ScrollableArea TextStream-loggable

• Status: RESOLVED
• Resolution: FIXED
• Component: Scrolling

[Simon Fraser (smfr)]

Make ScrollableArea TextStream-loggable

[Simon Fraser (smfr)]

Created attachment 395543 [details]
Patch

[Simon Fraser (smfr)]

Created attachment 395572 [details]
Patch

[Simon Fraser (smfr)]

Created attachment 395578 [details]
Patch

[Simon Fraser (smfr)]

Created attachment 395600 [details]
Patch

[Darin Adler]

Comment on attachment 395578 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395578&action=review

> Source/WebCore/page/FrameView.cpp:1437
> +    StringBuilder builder;
> +    builder.append("FrameView 0x"_s, hex(reinterpret_cast<uintptr_t>(this), Lowercase));
> +    builder.append(' ');
> +    builder.append(frame().debugDescription());
> +    return builder.toString();

Could use makeString here and a single line.

> Source/WebCore/platform/ScrollView.cpp:1540
> +    StringBuilder builder;
> +    builder.append("ScrollView 0x"_s, hex(reinterpret_cast<uintptr_t>(this), Lowercase));
> +    return builder.toString();

Could use makeString here.

> Source/WebCore/platform/win/PopupMenuWin.cpp:1091
> +    StringBuilder builder;
> +    builder.append("PopupMenuWin 0x"_s, hex(reinterpret_cast<uintptr_t>(this), Lowercase));
> +    return builder.toString();

makeString

> Source/WebCore/rendering/RenderLayer.cpp:3633
> +    builder.append("RenderLayer 0x"_s, hex(reinterpret_cast<uintptr_t>(this), Lowercase));
> +    builder.append(size().width(), 'x', size().height());

This can be one line.

> Source/WebCore/rendering/RenderListBox.cpp:916
> +String RenderListBox::debugDescription() const
> +{
> +    return RenderObject::debugDescription();
> +}

What is this for?

> Source/WebKit/UIProcess/win/WebPopupMenuProxyWin.cpp:1043
> +    StringBuilder builder;
> +    builder.append("WebPopupMenuProxyWin 0x"_s, hex(reinterpret_cast<uintptr_t>(this), Lowercase));
> +    return builder.toString();

makeString

> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:1291
> +    StringBuilder builder;
> +    builder.append("PDFPlugin 0x"_s, hex(reinterpret_cast<uintptr_t>(this), Lowercase));
> +    return builder.toString();

makeString

[Darin Adler]

Oops, reviewed the wrong one!

[Darin Adler]

Comment on attachment 395600 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395600&action=review

> Source/WebCore/rendering/RenderListBox.cpp:916
> +String RenderListBox::debugDescription() const
> +{
> +    return RenderObject::debugDescription();
> +}

What is this about? Why not just omit this override entirely?

[Simon Fraser (smfr)]

(In reply to Darin Adler from comment #7)
> Comment on attachment 395600 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=395600&action=review
> 
> > Source/WebCore/rendering/RenderListBox.cpp:916
> > +String RenderListBox::debugDescription() const
> > +{
> > +    return RenderObject::debugDescription();
> > +}
> 
> What is this about? Why not just omit this override entirely?

debugDescription() is in two base classes (RenderObject and ScrollableArea) and we need this to override the pure virtual one from ScrollableArea.

[EWS]

Committed r259597: <https://trac.webkit.org/changeset/259597>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395600 [details].

[Radar WebKit Bug Importer]

<rdar://problem/61360874>