Bug 210038 - [Clang 10] Fix -Wimplicit-int-float-conversion compilation warnings in JavaScriptCore
Summary: [Clang 10] Fix -Wimplicit-int-float-conversion compilation warnings in JavaSc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks: 204834
  Show dependency tree / graph
 
Reported: 2020-04-05 14:26 PDT by Fujii Hironori
Modified: 2020-04-06 13:09 PDT (History)
8 users (show)

See Also:

Attachments
Patch (2.12 KB, patch)
2020-04-05 14:32 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2020-04-05 14:26:14 PDT 
[Clang 10] Fix -Wimplicit-int-float-conversion compilation warnings in JavaScriptCore

This is a sub-task of Bug 204834.

Clang 10 reports a compilation warning in JavaScriptCore:

> ..\..\Source\JavaScriptCore\bytecode/CodeBlock.cpp(3002,24): warning: implicit conversion from 'unsigned long long' to 'double' changes value from 18446744073709551615 to 18446744073709551616 [-Wimplicit-int-float-conversion]
>     if (doubleResult > std::numeric_limits<size_t>::max())
>                      ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

See also: r259537 (which is for WTF)
Comment 1 Fujii Hironori 2020-04-05 14:32:56 PDT 
Created attachment 395528 [details]
Patch
Comment 2 Fujii Hironori 2020-04-06 13:08:16 PDT 
Comment on attachment 395528 [details]
Patch

Clearing flags on attachment: 395528

Committed r259588: <https://trac.webkit.org/changeset/259588>
Comment 3 Fujii Hironori 2020-04-06 13:08:20 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2020-04-06 13:09:14 PDT 
<rdar://problem/61355692>