Bug 210033 - [CMake] Add WebKit::WebKit target
Summary: [CMake] Add WebKit::WebKit target
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords:
: 201001 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-04-05 10:11 PDT by Don Olmstead
Modified: 2020-12-26 10:35 PST (History)
11 users (show)

See Also:

Attachments
WIP Patch (43.07 KB, patch)
2020-04-05 10:16 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (47.76 KB, patch)
2020-04-05 11:04 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2020-04-05 10:11:46 PDT 
Add the target and modernize the WebKit code around it.
Comment 1 Don Olmstead 2020-04-05 10:16:13 PDT Comment hidden (obsolete)
Comment 2 Don Olmstead 2020-04-05 11:04:06 PDT 
Created attachment 395517 [details]
Patch
Comment 3 Fujii Hironori 2020-04-05 19:21:26 PDT 
Comment on attachment 395517 [details]
Patch

LGTM
Comment 4 EWS 2020-04-05 20:02:59 PDT 
Committed r259560: <https://trac.webkit.org/changeset/259560>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395517 [details].
Comment 5 Don Olmstead 2020-04-06 08:01:23 PDT 
*** Bug 201001 has been marked as a duplicate of this bug. ***
Comment 6 Jim Mason 2020-04-08 01:29:27 PDT 
For me, WebKitPluginProcess is still built but is no longer installed.
Comment 7 Jim Mason 2020-04-08 01:33:28 PDT 
(In reply to Jim Mason from comment #6)
> For me, WebKitPluginProcess is still built but is no longer installed.

This is using the GTK port.
Comment 8 Alberto Garcia 2020-12-26 10:35:31 PST 
(In reply to Jim Mason from comment #6)
> For me, WebKitPluginProcess is still built but is no longer installed.

Thanks, I filed this as bug 220154