RESOLVED INVALID 210030
[GTK] update-webkit-flatpak doesn't work in Python3 
https://bugs.webkit.org/show_bug.cgi?id=210030
Summary [GTK] update-webkit-flatpak doesn't work in Python3
Alice Mikhaylenko
Reported 2020-04-05 09:45:38 PDT
``` ...rojects/WebKit/Tools/Scripts  ./update-webkit-flatpak Updating Flatpak Release environment Traceback (most recent call last): File "./update-webkit-flatpak", line 28, in <module> WebkitFlatpak.load_from_args(["--update"] + sys.argv[1:]).run() File "../../Tools/flatpak/flatpakutils.py", line 770, in run return self.main() File "../../Tools/flatpak/flatpakutils.py", line 766, in main return self.setup_dev_env() File "../../Tools/flatpak/flatpakutils.py", line 796, in setup_dev_env self.setup_icecc() File "../../Tools/flatpak/flatpakutils.py", line 790, in setup_icecc icc_version_filename, = re.findall(r'.*creating (.*)', tmpfile.read()) File "/usr/lib64/python3.8/re.py", line 239, in findall return _compile(pattern, flags).findall(string) TypeError: cannot use a string pattern on a bytes-like object ```
Attachments
Add attachment proposed patch, testcase, etc.
Alice Mikhaylenko
Comment 1 2020-04-05 09:47:48 PDT
Fedora 32, Python 3.8.2.
Philippe Normand
Comment 2 2020-04-05 10:36:04 PDT
flatpakutils is python2-only currently.
Alice Mikhaylenko
Comment 3 2020-04-05 10:39:45 PDT
Then it should use `python2` and not `python` which points to Python 3 here.
Philippe Normand
Comment 4 2020-04-05 10:52:59 PDT
Well, actually, with Python3.8.2 here the SDK installs fine: python3.8 Tools/Scripts/update-webkit-flatpak Adding repo webkit-sdk Updating Flatpak Release environment Adding repo flathub Installing from webkit-sdk org.webkit.Platform x86_64 0.2 Looking for matches… ID Branch Op Remote Download 1. [✓] org.webkit.Platform.Locale 0.2 i webkit-sdk 17.5 kB / 1.3 GB 2. [✓] org.webkit.Platform 0.2 i webkit-sdk 357.8 MB / 1.2 GB Installation complete. Installing from webkit-sdk org.webkit.Sdk x86_64 0.2 Looking for matches… ID Branch Op Remote Download 1. [✓] org.webkit.Sdk.Locale 0.2 i webkit-sdk 17.5 kB / 1.3 GB 2. [✓] org.webkit.Sdk 0.2 i webkit-sdk 486.7 MB / 2.3 GB Installation complete. Installing from flathub org.freedesktop.Platform.GL.default x86_64 19.08 Looking for matches… ID Branch Op Remote Download 1. [✓] org.freedesktop.Platform.GL.default 19.08 i flathub 94.4 MB / 94.9 MB Installation complete.
Alice Mikhaylenko
Comment 5 2020-04-05 10:59:59 PDT
Umm, I pulled and it works now. So apparently it was fixed and I had an old checkout.
Alice Mikhaylenko
Comment 6 2020-04-05 11:00:18 PDT
Wait, sorry, wrong issue /o\
Alice Mikhaylenko
Comment 7 2020-04-05 11:02:43 PDT
Actually this too, yes. Sorry :(
Note You need to log in before you can comment on or make changes to this bug.