Bug 209996 – Additional sanity checks in compareAnimationsByCompositeOrder()

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Doug Kelly]

compareAnimationsByCompositeOrder() is used by std::sort which requires strict weak ordering.  Add additional checks to ensure strict weak ordering is maintained.

<rdar://problem/60199826>

[Doug Kelly]

Created attachment 395427 [details]
Patch

[Geoffrey Garen]

Comment on attachment 395427 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395427&action=review

> Source/WebCore/animation/WebAnimationUtilities.cpp:87
> +        } else
> +            return !rhsIsCSSAnimation;

If you put this code first as an early return, you can eliminate the nested indentation for twenty lines of code above. I think that would read more clearly.

[Doug Kelly]

Comment on attachment 395427 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395427&action=review

>> Source/WebCore/animation/WebAnimationUtilities.cpp:87
>> +            return !rhsIsCSSAnimation;
> 
> If you put this code first as an early return, you can eliminate the nested indentation for twenty lines of code above. I think that would read more clearly.

I think that makes sense... it can probably apply to the same case above, too. :)

[Doug Kelly]

Created attachment 395450 [details]
Patch

[Geoffrey Garen]

Comment on attachment 395450 [details]
Patch

r=me

[EWS]

Committed r259538: <https://trac.webkit.org/changeset/259538>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395450 [details].