compareAnimationsByCompositeOrder() is used by std::sort which requires strict weak ordering. Add additional checks to ensure strict weak ordering is maintained. <rdar://problem/60199826>
Created attachment 395427 [details] Patch
Comment on attachment 395427 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395427&action=review > Source/WebCore/animation/WebAnimationUtilities.cpp:87 > + } else > + return !rhsIsCSSAnimation; If you put this code first as an early return, you can eliminate the nested indentation for twenty lines of code above. I think that would read more clearly.
Comment on attachment 395427 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395427&action=review >> Source/WebCore/animation/WebAnimationUtilities.cpp:87 >> + return !rhsIsCSSAnimation; > > If you put this code first as an early return, you can eliminate the nested indentation for twenty lines of code above. I think that would read more clearly. I think that makes sense... it can probably apply to the same case above, too. :)
Created attachment 395450 [details] Patch
Comment on attachment 395450 [details] Patch r=me
Committed r259538: <https://trac.webkit.org/changeset/259538> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395450 [details].