Bug 209994 - [iOS] WebPageProxy::didCommitLoadForFrame should not crash with null or empty `mimeType` parameter
Summary: [iOS] WebPageProxy::didCommitLoadForFrame should not crash with null or empty...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-03 17:58 PDT by David Kilzer (:ddkilzer)
Modified: 2020-04-08 13:05 PDT (History)
6 users (show)

See Also:

Attachments
Patch v1 (2.03 KB, patch)
2020-04-03 18:00 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Patch v2 (4.20 KB, patch)
2020-04-07 15:33 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2020-04-03 17:58:04 PDT 
WebPageProxy::didCommitLoadForFrame should validate its `mimeType` parameter.

<rdar://problem/60068700>
Comment 1 David Kilzer (:ddkilzer) 2020-04-03 18:00:32 PDT 
Created attachment 395423 [details]
Patch v1
Comment 2 David Kilzer (:ddkilzer) 2020-04-03 18:58:03 PDT 
Looks like the mimeType parameter can be nil (nullptr) with these tests:

TestWebKitAPI.WebKit.PendingAPIRequestURL
TestWebKitAPI.WebKit.LoadDataWithNilMIMEType
Comment 3 David Kilzer (:ddkilzer) 2020-04-04 06:10:37 PDT 
(In reply to David Kilzer (:ddkilzer) from comment #2)
> Looks like the mimeType parameter can be nil (nullptr) with these tests:
> 
> TestWebKitAPI.WebKit.PendingAPIRequestURL
> TestWebKitAPI.WebKit.LoadDataWithNilMIMEType

The api-ios bot only shows this test failing:

TestWebKitAPI.WebKit.LoadDataWithNilMIMEType
Comment 4 David Kilzer (:ddkilzer) 2020-04-07 15:33:02 PDT 
Created attachment 395751 [details]
Patch v2
Comment 5 EWS 2020-04-08 10:51:18 PDT 
Committed r259729: <https://trac.webkit.org/changeset/259729>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395751 [details].
Comment 6 Darin Adler 2020-04-08 11:49:38 PDT 
Comment on attachment 395751 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=395751&action=review

> Source/WebKit/UIProcess/mac/PageClientImplMac.mm:283
> +    UNUSED_PARAM(mimeType);
> +    UNUSED_PARAM(useCustomContentProvider);

Better to omit or comment out the argument names since that will give an error if we actually do use one, whereas if we use UNUSED_PARAM will keep compiling.
Comment 7 David Kilzer (:ddkilzer) 2020-04-08 13:05:41 PDT 
(In reply to Darin Adler from comment #6)
> Comment on attachment 395751 [details]
> Patch v2
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=395751&action=review
> 
> > Source/WebKit/UIProcess/mac/PageClientImplMac.mm:283
> > +    UNUSED_PARAM(mimeType);
> > +    UNUSED_PARAM(useCustomContentProvider);
> 
> Better to omit or comment out the argument names since that will give an
> error if we actually do use one, whereas if we use UNUSED_PARAM will keep
> compiling.

Committed r259750: <https://trac.webkit.org/changeset/259750>