Bug 209993 - TestWebKitAPI.WebKit.DefaultDisplayName and TestWebKitAPI.WebKit.CustomDisplayName are flaky failures
Summary: TestWebKitAPI.WebKit.DefaultDisplayName and TestWebKitAPI.WebKit.CustomDispla...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-03 17:16 PDT by Ryan Haddad
Modified: 2020-05-01 10:22 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.76 KB, patch)
2020-04-29 16:05 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2020-04-03 17:16:47 PDT 
TestWebKitAPI.WebKit.DefaultDisplayName is a flaky failure


    TestWebKitAPI.WebKit.DefaultDisplayName
        _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL.
        
        /Volumes/Data/slave/mojave-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm:69
        Expected equality of these values:
          name
            Which is: "com.apple.WebKit.WebContent"
          @"TestWebKitAPI Web Content"
            Which is: "TestWebKitAPI Web Content"
        

https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.WebKit.DefaultDisplayName
Comment 1 Radar WebKit Bug Importer 2020-04-03 17:17:02 PDT 
<rdar://problem/61282602>
Comment 2 Ryan Haddad 2020-04-03 17:19:02 PDT 
The test was added with https://trac.webkit.org/changeset/257225/webkit

The first failure I see on the results database is @ r258914

It isn't immediately clear to me when this regressed.
Comment 3 Ryan Haddad 2020-04-16 17:15:37 PDT 
TestWebKitAPI.WebKit.CustomDisplayName is also flaky (it was also added in r257225):

    TestWebKitAPI.WebKit.CustomDisplayName
        _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL.
        
        /Volumes/Data/slave/mojave-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm:55
        Expected equality of these values:
          name
            Which is: "TestWebKitAPI Web Content"
          displayNameToSet
            Which is: "test display name"

https://results.webkit.org/?suite=api-tests&suite=api-tests&test=TestWebKitAPI.WebKit.DefaultDisplayName&test=TestWebKitAPI.WebKit.CustomDisplayName
Comment 4 Alex Christensen 2020-04-29 16:05:39 PDT 
Created attachment 398005 [details]
Patch
Comment 5 EWS 2020-04-30 15:37:32 PDT 
Committed r260971: <https://trac.webkit.org/changeset/260971>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398005 [details].