Bug 209984 - [iOS] Simplify ProcessAssertion class in preparation for switch to RunningBoard
Summary: [iOS] Simplify ProcessAssertion class in preparation for switch to RunningBoard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 209990
  Show dependency tree / graph
 
Reported: 2020-04-03 13:54 PDT by Chris Dumez
Modified: 2020-04-06 08:27 PDT (History)
5 users (show)

See Also:

Attachments
Patch (38.52 KB, patch)
2020-04-03 14:07 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-04-03 13:54:38 PDT 
Simplify ProcessAssertion class in preparation for switch to RunningBoard. There is a slight mismatch between the way BKS and RunningBoard process assertion API. This refactoring makes it so that we can use the same ProcessAssertion class in WebKit to work with either BKS or RunningBoard. Support for RunningBoard will come later.
Comment 1 Radar WebKit Bug Importer 2020-04-03 13:54:52 PDT 
<rdar://problem/61273941>
Comment 2 Chris Dumez 2020-04-03 14:07:41 PDT 
Created attachment 395409 [details]
Patch
Comment 3 Darin Adler 2020-04-04 16:40:15 PDT 
Comment on attachment 395409 [details]
Patch

If reasons are always C++ literals, why store them in WTF::String? We could just store as const char* or maybe even as WTF::ASCIILiteral.
Comment 4 EWS 2020-04-04 17:03:52 PDT 
Committed r259540: <https://trac.webkit.org/changeset/259540>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395409 [details].
Comment 5 Chris Dumez 2020-04-06 08:27:52 PDT 
(In reply to Darin Adler from comment #3)
> Comment on attachment 395409 [details]
> Patch
> 
> If reasons are always C++ literals, why store them in WTF::String? We could
> just store as const char* or maybe even as WTF::ASCIILiteral.

Ok, will follow-up in https://bugs.webkit.org/show_bug.cgi?id=210049.