Update test262 to commit 62b8fce38971
Created attachment 395399 [details] Patch
I think you'll need to set the 'allow-tabs' svn property on the lgcl JS files or your patch is going to get rejected by the svn commit hook.
(In reply to Keith Miller from comment #2) > I think you'll need to set the 'allow-tabs' svn property on the lgcl JS > files or your patch is going to get rejected by the svn commit hook. We should fix this upstream too. :(
Oh oops, I was being silly. Those three files (lgcl-*-whitespace.js) are using tabs intentionally and appear to be marked as "binary" in test262. So we can either `svn propset` or, say, add JSTests/.gitattributes.
I've checked out using SVN, applied the patch and performed $ svn propset "allow-tabs" "1" on lgcl-*-whitespace.js files, but I am getting ERROR: Unexpected diff format when parsing a chunk: '' ERROR: Unexpected diff format when parsing a chunk: 'Property changes on: JSTests/test262/test/language/expressions/logical-assignment/lgcl-and-whitespace.js' ERROR: Unexpected diff format when parsing a chunk: '___________________________________________________________________' ERROR: Unexpected diff format when parsing a chunk: 'Added: allow-tabs' ERROR: Unexpected diff format when parsing a chunk: '## -0,0 +1 ##' ERROR: Unexpected diff format when parsing a chunk: '\\ No newline at end of property' ERROR: JSTests/test262/test/language/expressions/logical-assignment/lgcl-and-whitespace.js:15: Line contains tab character. [whitespace/tab] [5] ERROR: JSTests/test262/test/language/expressions/logical-assignment/lgcl-and-whitespace.js:55: Line contains tab character. [whitespace/tab] [5] ERROR: JSTests/test262/test/language/expressions/logical-assignment/lgcl-and-whitespace.js:56: Line contains tab character. [whitespace/tab] [5] during `webkit-patch upload`. Please see https://bugs.webkit.org/show_bug.cgi?id=186624: seems like we would have to land this manually.
Yeah, it's not an ideal situation... It may be better to add a JSTests/.gitattributes, listing off each problematic file, like this: https://github.com/WebKit/webkit/blob/master/Source/WTF/icu/unicode/.gitattributes ...that way it can still go through the commit queue.
I brought up the allow-tabs problem awhile ago in webkit-dev but it fizzled out because I couldn't find the commit hook source and I never asked where it was. I restarted the thread so maybe we can improve our situation.
Created attachment 395436 [details] Patch Add JSTests/.gitattributes
(In reply to Ross Kirsling from comment #6) > Yeah, it's not an ideal situation... > > It may be better to add a JSTests/.gitattributes, listing off each > problematic file, like this: > https://github.com/WebKit/webkit/blob/master/Source/WTF/icu/unicode/. > gitattributes > > ...that way it can still go through the commit queue. Thank you, Ross. Per your previous comment, I was looking through .gitattributes in /Source, but didn't find anything related to tabs.
(In reply to Keith Miller from comment #7) > I brought up the allow-tabs problem awhile ago in webkit-dev but it fizzled > out because I couldn't find the commit hook source and I never asked where > it was. I restarted the thread so maybe we can improve our situation. Thanks Keith!
Committed r259529: <https://trac.webkit.org/changeset/259529> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395436 [details].
<rdar://problem/61290124>