[JSC] TypedArray#subarray should throw OOM error gracefully
Created attachment 395392 [details] Patch
<rdar://problem/61253901>
Comment on attachment 395392 [details] Patch r=me
Committed r259478: <https://trac.webkit.org/changeset/259478>
> Committed r259478: <https://trac.webkit.org/changeset/259478> The newly added test stress/typed-array-subarray-can-throw-oom-error.js seems to be failing consistently on jsc-armv7 and jsc-mips. History: https://results.webkit.org/?suite=javascriptcore-tests&suite=javascriptcore-tests&suite=javascriptcore-tests&suite=javascriptcore-tests&test=stress%2Ftyped-array-subarray-can-throw-oom-error.js.default&test=stress%2Ftyped-array-subarray-can-throw-oom-error.js.dfg-eager&test=stress%2Ftyped-array-subarray-can-throw-oom-error.js.dfg-eager-no-cjit-validate&test=stress%2Ftyped-array-subarray-can-throw-oom-error.js.eager-jettison-no-cjit
I've skipped the test for armv7 and mips in r259530: <http://trac.webkit.org/r259530>, and filed https://bugs.webkit.org/show_bug.cgi?id=210003 for the root cause to be investigated.
(In reply to Mark Lam from comment #6) > I've skipped the test for armv7 and mips in r259530: > <http://trac.webkit.org/r259530>, and filed > https://bugs.webkit.org/show_bug.cgi?id=210003 for the root cause to be > investigated. I think you'll just want to skip if $memoryLimited (might be a different name). These failures sometimes cause problems on iOS testing too.
(In reply to Keith Miller from comment #7) > (In reply to Mark Lam from comment #6) > > I've skipped the test for armv7 and mips in r259530: > > <http://trac.webkit.org/r259530>, and filed > > https://bugs.webkit.org/show_bug.cgi?id=210003 for the root cause to be > > investigated. > > I think you'll just want to skip if $memoryLimited (might be a different > name). These failures sometimes cause problems on iOS testing too. Yes, looks like this is timeout because these bots are slow.
Committed r259535: <https://trac.webkit.org/changeset/259535>