Bug 209973 – Remove _setIsNavigatingToAppBoundDomain testing SPI

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Kate Cheney]

We no longer need a testing SPI to set a webView as navigating to an app-bound domain. We can just load a local file.

[Radar WebKit Bug Importer]

<rdar://problem/61264350>

[Kate Cheney]

Created attachment 395390 [details]
Patch

[David Kilzer (:ddkilzer)]

Comment on attachment 395390 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395390&action=review

r=me assuming EWS passes.  Consider renaming `request2` as well.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:239
> +    NSURLRequest *request2 = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"in-app-browser-privacy-local-file" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];

Nit: `request2` isn't a great variable name.  Better to reuse `request` from above (since it's no longer used), or change it to something like `localFileRequest` or `fileRequest`.

[Kate Cheney]

Created attachment 395406 [details]
Patch for landing

[Kate Cheney]

(In reply to David Kilzer (:ddkilzer) from comment #3)
> Comment on attachment 395390 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=395390&action=review
> 
> r=me assuming EWS passes.  Consider renaming `request2` as well.
> 
> > Tools/TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:239
> > +    NSURLRequest *request2 = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"in-app-browser-privacy-local-file" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
> 
> Nit: `request2` isn't a great variable name.  Better to reuse `request` from
> above (since it's no longer used), or change it to something like
> `localFileRequest` or `fileRequest`.

Thanks! I reused 'request' in the patch for landing.

[EWS]

Committed r259507: <https://trac.webkit.org/changeset/259507>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395406 [details].