WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
209965
[ews] Improve error message when patch fails to apply to trunk
https://bugs.webkit.org/show_bug.cgi?id=209965
Summary
[ews] Improve error message when patch fails to apply to trunk
Aakash Jain
Reported
2020-04-03 07:25:57 PDT
[ews] Improve error message when patch fails to apply to trunk. Current error message is 'Patch does not apply', this might be confusing for few people (especially new contributors). Better wording would be: 'Tools/Scripts/svn-apply failed to apply patch 123456 to trunk'.
Attachments
Patch
(3.89 KB, patch)
2020-04-03 07:30 PDT
,
Aakash Jain
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Aakash Jain
Comment 1
2020-04-03 07:30:37 PDT
Created
attachment 395374
[details]
Patch
Aakash Jain
Comment 2
2020-04-03 07:31:33 PDT
Sample run:
https://ews-build.webkit-uat.org/#/builders/34/builds/137
Sample bug comment:
https://bugs.webkit.org/show_bug.cgi?id=179531#c35
EWS
Comment 3
2020-04-03 09:26:57 PDT
Committed
r259464
: <
https://trac.webkit.org/changeset/259464
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 395374
[details]
.
Radar WebKit Bug Importer
Comment 4
2020-04-03 09:27:13 PDT
<
rdar://problem/61262348
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug