Bug 209956 – [Flatpak SDK] Call setup_icecc only if use_icecream is defined

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Diego Pino]

[Flatpak SDK] Call setup_icecc only if use_icecream is defined

[Diego Pino]

Created attachment 395356 [details]
Patch

[Diego Pino]

I noticed on a host without icecc installed, calls to "Tools/Script/update-webkitwpe-libs" end up on the following error:

```
$ Tools/Scripts/update-webkitwpe-libs 
Updating Flatpak Release environment
error: Unable to allocate instance id
Command '['flatpak', 'build', '--die-with-parent', '--talk-name=org.a11y.Bus', '--talk-name=org.gtk.vfs', '--talk-name=org.gtk.vfs.*', '--bind-mount=/run/shm=/dev/shm', '--bind-mount=/run/host//tmp=/tmp', '--bind-mount=/run/systemd/journal=/run/systemd/journal', '--bind-mount=/app/webkit=/home/dpino/workspace/webkit-wpe', '--bind-mount=/app/webkit/WebKitBuild/Release=/home/dpino/workspace/webkit-wpe/WebKitBuild/GTK/Release', '--device=all', '--device=dri', '--filesystem=host', '--share=ipc', '--share=network', '--socket=pulseaudio', '--socket=system-bus', '--socket=wayland', '--socket=x11', '--system-talk-name=org.a11y.Bus', '--system-talk-name=org.freedesktop.GeoClue2', '--talk-name=org.a11y.Bus', '--talk-name=org.freedesktop.Flatpak', '--env=LANG=en_US.UTF-8', '--env=TZ=PST8PDT', '--env=WAYLAND_DISPLAY=wayland-0', '--env=DISPLAY=:0', '--env=WEBKIT_TOP_LEVEL=/app/', '--env=TEST_RUNNER_INJECTED_BUNDLE_FILENAME=/app/webkit/WebKitBuild/Release/lib/libTestRunnerInjectedBundle.so', '/home/dpino/workspace/webkit-wpe/WebKitBuild/UserFlatpak', 'icecc', '--build-native']' returned non-zero exit status 1
```

I think function setup_icecc(), which ends up running icecc, should only be called if flag use_icecream was set.

[EWS]

Committed r259450: <https://trac.webkit.org/changeset/259450>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395356 [details].

[Radar WebKit Bug Importer]

<rdar://problem/61250913>