Bug 209954 - [Flatpak SDK] Create platform/Release directory only when build-webkit is called
Summary: [Flatpak SDK] Create platform/Release directory only when build-webkit is called
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Diego Pino
URL:
Keywords: InRadar
Depends on:
Blocks: 209960
  Show dependency tree / graph
 
Reported: 2020-04-03 00:51 PDT by Diego Pino
Modified: 2020-04-03 04:58 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.22 KB, patch)
2020-04-03 00:51 PDT, Diego Pino 		no flags Details | Formatted Diff | Diff
Patch (2.77 KB, patch)
2020-04-03 02:35 PDT, Diego Pino 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2020-04-03 00:51:18 PDT 
[WPE] Pass --wpe argument to update-webkit-flatpak
Comment 1 Diego Pino 2020-04-03 00:51:33 PDT 
Created attachment 395355 [details]
Patch
Comment 2 Diego Pino 2020-04-03 00:57:57 PDT 
On calling `Tools/Scripts/update-webkitwpe-libs`, script `update-webkit-flatpak` is called without platform name (--wpe), taking GTK as default. As a result, flatpak argument '--bind-mount=/app/webkit/WebKitBuild/Release' points to '../WebKitBuild/GTK/Release', when it should point to '../WebKitBuild/WPE/Release'. Another consequence is that 'WebKitBuild/GTK' folder is created.
Comment 3 Philippe Normand 2020-04-03 01:09:05 PDT 
This shouldn't be necessary, because the same SDK is used for both GTK and WPE.
Comment 4 Philippe Normand 2020-04-03 01:36:27 PDT 
(In reply to Diego Pino from comment #2)
> On calling `Tools/Scripts/update-webkitwpe-libs`, script
> `update-webkit-flatpak` is called without platform name (--wpe), taking GTK
> as default. As a result, flatpak argument
> '--bind-mount=/app/webkit/WebKitBuild/Release' points to
> '../WebKitBuild/GTK/Release', when it should point to
> '../WebKitBuild/WPE/Release'. Another consequence is that 'WebKitBuild/GTK'
> folder is created.

Regarding this, perhaps we can simply avoid to mkdir the build directory unless we're being called by build-webkit.
Comment 5 Diego Pino 2020-04-03 02:35:49 PDT 
Created attachment 395360 [details]
Patch
Comment 6 EWS 2020-04-03 04:10:43 PDT 
Committed r259453: <https://trac.webkit.org/changeset/259453>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395360 [details].
Comment 7 Radar WebKit Bug Importer 2020-04-03 04:11:16 PDT 
<rdar://problem/61253950>