Bug 209949 - FileSystem handle leaks in CurlCacheManager and NetworkCacheData when failed to open a file
Summary: FileSystem handle leaks in CurlCacheManager and NetworkCacheData when failed ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-02 20:09 PDT by Yousuke Kimoto
Modified: 2020-04-03 01:40 PDT (History)
6 users (show)

See Also:

Attachments
patch (2.94 KB, patch)
2020-04-02 20:26 PDT, Yousuke Kimoto 		no flags Details | Formatted Diff | Diff
patch (2.98 KB, patch)
2020-04-02 22:27 PDT, Yousuke Kimoto 		Hironori.Fujii: review+
Details | Formatted Diff | Diff
patch (2.98 KB, patch)
2020-04-02 23:10 PDT, Yousuke Kimoto 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuke Kimoto 2020-04-02 20:09:44 PDT 
CurlCacheManager and NetwrorkCacheData uses FileSystem class's file handle, which leaks  when it fails to open the file.
Comment 1 Yousuke Kimoto 2020-04-02 20:26:12 PDT 
Created attachment 395340 [details]
patch
Comment 2 Yousuke Kimoto 2020-04-02 22:27:36 PDT 
Created attachment 395348 [details]
patch
Comment 3 Fujii Hironori 2020-04-02 23:02:49 PDT 
Comment on attachment 395348 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395348&action=review

> Source/WebCore/ChangeLog:9
> +        return its status. The handle should be relased before returning.

relased → released
Comment 4 Yousuke Kimoto 2020-04-02 23:09:17 PDT 
>> Source/WebCore/ChangeLog:9
>> +        return its status. The handle should be relased before returning.
> 
>relased → released
Thank you. I'll fix it.
Comment 5 Yousuke Kimoto 2020-04-02 23:10:48 PDT 
Created attachment 395351 [details]
patch
Comment 6 Yousuke Kimoto 2020-04-03 01:27:14 PDT 
Fujii-san, thank you for your quick review!
Comment 7 EWS 2020-04-03 01:39:04 PDT 
Committed r259449: <https://trac.webkit.org/changeset/259449>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395351 [details].
Comment 8 Radar WebKit Bug Importer 2020-04-03 01:40:14 PDT 
<rdar://problem/61249927>