RESOLVED FIXED 20994
HTMLVideoElement width and height attributes are now unsigned 
https://bugs.webkit.org/show_bug.cgi?id=20994
Summary HTMLVideoElement width and height attributes are now unsigned
Eric Carlson
Reported 2008-09-22 09:21:21 PDT
HTMLVideoElement width and height attributes were originally signed, now they are unsigned. http://www.whatwg.org/specs/web-apps/current-work/multipage/video.html#htmlvideoelement
Attachments
proposed patch (1.34 KB, patch)
2008-09-22 09:25 PDT, Eric Carlson 		sam: review-
DetailsFormatted DiffDiff
Revised patch (3.95 KB, patch)
2008-09-22 10:59 PDT, Eric Carlson 		sam: review-
DetailsFormatted DiffDiff
Revised patch (4.99 KB, patch)
2008-09-25 09:56 PDT, Eric Carlson 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2008-09-22 09:25:08 PDT
Created attachment 23653 [details] proposed patch
Sam Weinig
Comment 2 2008-09-22 10:30:31 PDT
Comment on attachment 23653 [details] proposed patch You need to change the c++ files to return unsigned as well. r-
Eric Carlson
Comment 3 2008-09-22 10:59:47 PDT
Created attachment 23656 [details] Revised patch Update c++ files to take and return unsigned, make videoWidth and videoHeight return unsigned to match idl.
Sam Weinig
Comment 4 2008-09-22 14:17:31 PDT
Comment on attachment 23656 [details] Revised patch + unsigned w = getAttribute(widthAttr).toInt(&ok); + unsigned h = getAttribute(heightAttr).toInt(&ok); These need to use toUInt().
Eric Carlson
Comment 5 2008-09-25 09:56:56 PDT
Created attachment 23801 [details] Revised patch Convert all unsigned attributes with toUInt().
Sam Weinig
Comment 6 2008-09-27 13:11:12 PDT
Comment on attachment 23801 [details] Revised patch Woot! r=me
Eric Carlson
Comment 7 2008-09-27 22:46:19 PDT
Third time was a charm. Committed as revision 37030.
Note You need to log in before you can comment on or make changes to this bug.