On iOS, after <https://trac.webkit.org/changeset/258180/webkit>, mach lookup access to "com.apple.runningboard" can be denied in the WebContent process.
rdar://problem/56995639
Created attachment 395311 [details] Patch
Comment on attachment 395311 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395311&action=review r=me > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:561 > +(deny mach-lookup (with telemetry-backtrace) Hooray!
Comment on attachment 395311 [details] Patch Thanks for reviewing!
Committed r259469: <https://trac.webkit.org/changeset/259469> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395311 [details].
Comment on attachment 395311 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395311&action=review > Source/WebKit/ChangeLog:9 > + On iOS, after <https://trac.webkit.org/changeset/258180/webkit>, mach lookup access to "com.apple.runningboard" How can this be true? We still take a RunningBoard DependencyAssertion in the WebProcess. I suspect this broke media (again).
(In reply to Chris Dumez from comment #6) > Comment on attachment 395311 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=395311&action=review > > > Source/WebKit/ChangeLog:9 > > + On iOS, after <https://trac.webkit.org/changeset/258180/webkit>, mach lookup access to "com.apple.runningboard" > > How can this be true? We still take a RunningBoard DependencyAssertion in > the WebProcess. I suspect this broke media (again). + Jer/ Eric
(In reply to Chris Dumez from comment #6) > Comment on attachment 395311 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=395311&action=review > > > Source/WebKit/ChangeLog:9 > > + On iOS, after <https://trac.webkit.org/changeset/258180/webkit>, mach lookup access to "com.apple.runningboard" > > How can this be true? We still take a RunningBoard DependencyAssertion in > the WebProcess. I suspect this broke media (again). I don't think calling 'm_uiProcessDependencyProcessAssertion = makeUnique<DependencyProcessAssertion>(remoteProcessID, "WebContent process dependency on UIProcess"_s)' in the WebContent process will need access to the runningboard service.
(In reply to Per Arne Vollan from comment #8) > (In reply to Chris Dumez from comment #6) > > Comment on attachment 395311 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=395311&action=review > > > > > Source/WebKit/ChangeLog:9 > > > + On iOS, after <https://trac.webkit.org/changeset/258180/webkit>, mach lookup access to "com.apple.runningboard" > > > > How can this be true? We still take a RunningBoard DependencyAssertion in > > the WebProcess. I suspect this broke media (again). > > I don't think calling 'm_uiProcessDependencyProcessAssertion = > makeUnique<DependencyProcessAssertion>(remoteProcessID, "WebContent process > dependency on UIProcess"_s)' in the WebContent process will need access to > the runningboard service. That would be good news. As long as you have verified that then I guess we're good. Breakage would not be obvious but you would definitely see sandbox violations if things were not working I think.
Re-opened since this is blocked by bug 210066
Created attachment 395739 [details] Patch
This likely needs updating after http://trac.webkit.org/changeset/259674/webkit.
Created attachment 395752 [details] Patch
(In reply to Chris Dumez from comment #12) > This likely needs updating after > http://trac.webkit.org/changeset/259674/webkit. Thanks!
Comment on attachment 395752 [details] Patch Ok, assuming you have verified that the assertion reliably gets taken at RunningBoard level and does not get invalidated.
(In reply to Chris Dumez from comment #15) > Comment on attachment 395752 [details] > Patch > > Ok, assuming you have verified that the assertion reliably gets taken at > RunningBoard level and does not get invalidated. Yes, I have confirmed that the creation of the dependency assertion succeeds, and manually tested the audio playback scenario. Thanks for reviewing!
Created attachment 395758 [details] Patch
Committed r259700: <https://trac.webkit.org/changeset/259700> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395758 [details].