Bug 20993 - Array.push/pop need optimized cases for JSArray
Summary: Array.push/pop need optimized cases for JSArray
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-22 09:15 PDT by Darin Adler
Modified: 2008-09-22 14:05 PDT (History)
0 users

See Also:

Attachments
work in progress (5.49 KB, patch)
2008-09-22 09:15 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
patch (6.59 KB, patch)
2008-09-22 13:51 PDT, Darin Adler 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2008-09-22 09:15:02 PDT 
The deltablue benchmark uses Array.push/pop a lot, and we need faster versions.
Comment 1 Darin Adler 2008-09-22 09:15:38 PDT 
Created attachment 23652 [details]
work in progress

Seems to be correct and fast on deltablue, but slows down SunSpider for some reason.
Comment 2 Darin Adler 2008-09-22 13:01:12 PDT 
Maciej tested it and said that it didn't slow SunSpider down for him. Hooray!
Comment 3 Darin Adler 2008-09-22 13:51:47 PDT 
Created attachment 23666 [details]
patch
Comment 4 Darin Adler 2008-09-22 14:05:17 PDT 
http://trac.webkit.org/changeset/36778