Bug 209925 – HTMLFormElement should use WeakPtr to keep track of its FormNamedItem

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Ryosuke Niwa]

Right now HTMLFormElement uses a HashMap of AtomString to a raw pointer of FormNamedItem.
We should replace the latter with WeakPtr to the equivalent HTMLElement.

[Ryosuke Niwa]

Created attachment 395298 [details]
Deploys WeakPtr

[Wenson Hsieh]

Comment on attachment 395298 [details]
Deploys WeakPtr

The windows EWS test failures seem unrelated.

[Ryosuke Niwa]

(In reply to Wenson Hsieh from comment #2)
> Comment on attachment 395298 [details]
> Deploys WeakPtr
> 
> The windows EWS test failures seem unrelated.

Yup, indeed it's been cleared now.

[Ryosuke Niwa]

Committed r259513: <https://trac.webkit.org/changeset/259513>

[Radar WebKit Bug Importer]

<rdar://problem/61274486>

[David Kilzer (:ddkilzer)]

(In reply to Ryosuke Niwa from comment #4)
> Committed r259513: <https://trac.webkit.org/changeset/259513>

Build fix:

Committed r259527: <https://trac.webkit.org/changeset/259527>

[Ryosuke Niwa]

(In reply to David Kilzer (:ddkilzer) from comment #6)
> (In reply to Ryosuke Niwa from comment #4)
> > Committed r259513: <https://trac.webkit.org/changeset/259513>
> 
> Build fix:
> 
> Committed r259527: <https://trac.webkit.org/changeset/259527>

Oh oops, thanks for the build fix but that's wrong :( We shouldn't be enabling this assertions even when security assertions are enabled.

[David Kilzer (:ddkilzer)]

(In reply to Ryosuke Niwa from comment #7)
> (In reply to David Kilzer (:ddkilzer) from comment #6)
> > (In reply to Ryosuke Niwa from comment #4)
> > > Committed r259513: <https://trac.webkit.org/changeset/259513>
> > 
> > Build fix:
> > 
> > Committed r259527: <https://trac.webkit.org/changeset/259527>
> 
> Oh oops, thanks for the build fix but that's wrong :( We shouldn't be
> enabling this assertions even when security assertions are enabled.

Committed r259543: <https://trac.webkit.org/changeset/259543>

[Ryosuke Niwa]

(In reply to David Kilzer (:ddkilzer) from comment #8)
> (In reply to Ryosuke Niwa from comment #7)
> > (In reply to David Kilzer (:ddkilzer) from comment #6)
> > > (In reply to Ryosuke Niwa from comment #4)
> > > > Committed r259513: <https://trac.webkit.org/changeset/259513>
> > > 
> > > Build fix:
> > > 
> > > Committed r259527: <https://trac.webkit.org/changeset/259527>
> > 
> > Oh oops, thanks for the build fix but that's wrong :( We shouldn't be
> > enabling this assertions even when security assertions are enabled.
> 
> Committed r259543: <https://trac.webkit.org/changeset/259543>

Thanks!