Right now HTMLFormElement uses a HashMap of AtomString to a raw pointer of FormNamedItem. We should replace the latter with WeakPtr to the equivalent HTMLElement.
Created attachment 395298 [details] Deploys WeakPtr
Comment on attachment 395298 [details] Deploys WeakPtr The windows EWS test failures seem unrelated.
(In reply to Wenson Hsieh from comment #2) > Comment on attachment 395298 [details] > Deploys WeakPtr > > The windows EWS test failures seem unrelated. Yup, indeed it's been cleared now.
Committed r259513: <https://trac.webkit.org/changeset/259513>
<rdar://problem/61274486>
(In reply to Ryosuke Niwa from comment #4) > Committed r259513: <https://trac.webkit.org/changeset/259513> Build fix: Committed r259527: <https://trac.webkit.org/changeset/259527>
(In reply to David Kilzer (:ddkilzer) from comment #6) > (In reply to Ryosuke Niwa from comment #4) > > Committed r259513: <https://trac.webkit.org/changeset/259513> > > Build fix: > > Committed r259527: <https://trac.webkit.org/changeset/259527> Oh oops, thanks for the build fix but that's wrong :( We shouldn't be enabling this assertions even when security assertions are enabled.
(In reply to Ryosuke Niwa from comment #7) > (In reply to David Kilzer (:ddkilzer) from comment #6) > > (In reply to Ryosuke Niwa from comment #4) > > > Committed r259513: <https://trac.webkit.org/changeset/259513> > > > > Build fix: > > > > Committed r259527: <https://trac.webkit.org/changeset/259527> > > Oh oops, thanks for the build fix but that's wrong :( We shouldn't be > enabling this assertions even when security assertions are enabled. Committed r259543: <https://trac.webkit.org/changeset/259543>
(In reply to David Kilzer (:ddkilzer) from comment #8) > (In reply to Ryosuke Niwa from comment #7) > > (In reply to David Kilzer (:ddkilzer) from comment #6) > > > (In reply to Ryosuke Niwa from comment #4) > > > > Committed r259513: <https://trac.webkit.org/changeset/259513> > > > > > > Build fix: > > > > > > Committed r259527: <https://trac.webkit.org/changeset/259527> > > > > Oh oops, thanks for the build fix but that's wrong :( We shouldn't be > > enabling this assertions even when security assertions are enabled. > > Committed r259543: <https://trac.webkit.org/changeset/259543> Thanks!