Bug 209922 - Move Intl tests from LayoutTests to JSTests
Summary: Move Intl tests from LayoutTests to JSTests
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
Keywords: InRadar
Depends on:
Reported: 2020-04-02 13:22 PDT by Ross Kirsling
Modified: 2020-04-06 19:09 PDT (History)
8 users (show)

See Also:

Patch (655.43 KB, patch)
2020-04-02 13:34 PDT, Ross Kirsling
no flags Details | Formatted Diff | Diff
Patch (655.47 KB, patch)
2020-04-02 14:50 PDT, Ross Kirsling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2020-04-02 13:22:43 PDT
Move Intl API tests from LayoutTests to JSTests
Comment 1 Ross Kirsling 2020-04-02 13:34:11 PDT
Created attachment 395292 [details]
Comment 2 Ross Kirsling 2020-04-02 13:39:57 PDT
Sorry if this is a bit tricky to review due to updating the assertion style of the test cases.

I do recommend that we migrate tests from LayoutTests/js to JSTests/stress any time we're bitten by them as a general practice, but I might not necessarily recommend taking the time to update the assertion style like this in the future.
Comment 3 Ross Kirsling 2020-04-02 14:36:39 PDT
Grr, I tried to relax the skips a bit, but apparently that part will need to wait until after bug 209694.
Comment 4 Ross Kirsling 2020-04-02 14:50:07 PDT
Created attachment 395304 [details]
Comment 5 Yusuke Suzuki 2020-04-03 03:23:17 PDT
Comment on attachment 395304 [details]

Comment 6 EWS 2020-04-03 11:34:58 PDT
Committed r259480: <https://trac.webkit.org/changeset/259480>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395304 [details].
Comment 7 Radar WebKit Bug Importer 2020-04-03 11:35:16 PDT