Bug 20992 - Build fails on GTK+ Mac OS
Summary: Build fails on GTK+ Mac OS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-22 08:54 PDT by Richard Hult
Modified: 2008-09-24 00:45 PDT (History)
0 users

See Also:


Attachments
remove platform ifdefs on ThreadingGtk (1.23 KB, patch)
2008-09-23 17:10 PDT, Jan Alonzo
alp: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Hult 2008-09-22 08:54:46 PDT
JavaScriptCore/wtf/ThreadingGtk.cpp has this snippet at the beginning:

#if !PLATFORM(DARWIN)
static ThreadIdentifier mainThreadIdentifier;
#endif

Later in the same file the variable is used unconditionally, causing a build error when building with GTK+ on Mac OS. I'm not sure why it is conditionalized at all, my guess is that the right fix is to just remove the #if.
Comment 1 Jan Alonzo 2008-09-23 17:10:42 PDT
Created attachment 23736 [details]
remove platform ifdefs on ThreadingGtk

Removed platform ifdef as suggested by Richard.
Comment 2 Eric Seidel (no email) 2008-09-23 19:58:32 PDT
Comment on attachment 23736 [details]
remove platform ifdefs on ThreadingGtk

There was a separate bug about this which I reviewed recently and had a different fix.  I thought that had landed already.  Are you sure you're up to date?
Comment 3 Eric Seidel (no email) 2008-09-23 19:59:22 PDT
Comment on attachment 23736 [details]
remove platform ifdefs on ThreadingGtk

Oh, nevermind.  I think I was thinking of Qt.  This code was probably copied from Qt, and probably doesn't need those #ifdefs.
Comment 4 Alp Toker 2008-09-23 20:40:49 PDT
Comment on attachment 23736 [details]
remove platform ifdefs on ThreadingGtk

r=me
Comment 5 Jan Alonzo 2008-09-24 00:45:21 PDT
landed in r36846