JavaScriptCore/wtf/ThreadingGtk.cpp has this snippet at the beginning: #if !PLATFORM(DARWIN) static ThreadIdentifier mainThreadIdentifier; #endif Later in the same file the variable is used unconditionally, causing a build error when building with GTK+ on Mac OS. I'm not sure why it is conditionalized at all, my guess is that the right fix is to just remove the #if.
Created attachment 23736 [details] remove platform ifdefs on ThreadingGtk Removed platform ifdef as suggested by Richard.
Comment on attachment 23736 [details] remove platform ifdefs on ThreadingGtk There was a separate bug about this which I reviewed recently and had a different fix. I thought that had landed already. Are you sure you're up to date?
Comment on attachment 23736 [details] remove platform ifdefs on ThreadingGtk Oh, nevermind. I think I was thinking of Qt. This code was probably copied from Qt, and probably doesn't need those #ifdefs.
Comment on attachment 23736 [details] remove platform ifdefs on ThreadingGtk r=me
landed in r36846