Bug 209903 - Video previews on shutterstock.com don't play when tapped on iPadOS
Summary: Video previews on shutterstock.com don't play when tapped on iPadOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-02 06:36 PDT by Antoine Quint
Modified: 2020-04-02 08:58 PDT (History)
17 users (show)

See Also:

Attachments
Patch (25.46 KB, patch)
2020-04-02 06:40 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch (4.34 KB, patch)
2020-04-02 08:07 PDT, Antoine Quint 		wenson_hsieh: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2020-04-02 06:36:27 PDT 
Video previews on shutterstock.com don't play when tapped on iPadOS
Comment 1 Antoine Quint 2020-04-02 06:40:15 PDT 
Created attachment 395264 [details]
Patch
Comment 2 Antoine Quint 2020-04-02 06:40:20 PDT 
<rdar://problem/58844166>
Comment 3 Wenson Hsieh 2020-04-02 07:57:31 PDT 
Comment on attachment 395264 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395264&action=review

> Source/WebCore/loader/DocumentLoader.h:138
> +    Allow,
> +    Deny,

Nit - sounds a bit weird for a `CanPrevent~` enum to have values of Allow and Deny. Maybe just Default, No, and Yes?
Comment 4 Antoine Quint 2020-04-02 08:07:20 PDT 
Created attachment 395267 [details]
Patch
Comment 5 Antoine Quint 2020-04-02 08:54:24 PDT 
(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 395264 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=395264&action=review
> 
> > Source/WebCore/loader/DocumentLoader.h:138
> > +    Allow,
> > +    Deny,
> 
> Nit - sounds a bit weird for a `CanPrevent~` enum to have values of Allow
> and Deny. Maybe just Default, No, and Yes?

The newer patch removes the desktop-specific part of the quirk.
Comment 6 Antoine Quint 2020-04-02 08:58:18 PDT 
Committed r259387: <https://trac.webkit.org/changeset/259387>