Bug 209897 – [Windows] Ignore render tree dump based results on Windows

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Antti Koivisto]

Render tree dumps are port specific and so difficult to maintain. They are mostly very old and have been superseded by more modern ref and text dump tests. They rarely reveal any port specific bugs.

[Antti Koivisto]

Created attachment 395251 [details]
patch

[Antti Koivisto]

Created attachment 395252 [details]
patch

[EWS]

Committed r259446: <https://trac.webkit.org/changeset/259446>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395252 [details].

[Radar WebKit Bug Importer]

<rdar://problem/61247373>

[Truitt Savell]

Reverted r259446 for reason:

Broke Windows testing

Committed r259667: <https://trac.webkit.org/changeset/259667>

[Ryan Haddad]

Example of failure:
https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Tests%29/builds/5456

02:05:39.348 2864 worker/2: TypeError('expected string or buffer') raised:
02:05:39.352 2864     File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/common/message_pool.py", line 280, in run
02:05:39.352 2864       worker.handle(message.name, message.src, *message.args)
02:05:39.352 2864     File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 291, in handle
02:05:39.352 2864       self._run_test(test_input, test_list_name)
02:05:39.352 2864     File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 317, in _run_test
02:05:39.352 2864       result = self._run_test_with_or_without_timeout(test_input, test_timeout_sec, stop_when_done)
02:05:39.352 2864     File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 383, in _run_test_with_or_without_timeout
02:05:39.352 2864       return self._run_test_in_this_thread(test_input, stop_when_done)
02:05:39.353 2864     File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 469, in _run_test_in_this_thread
02:05:39.353 2864       return self._run_single_test(self._driver, test_input, stop_when_done)
02:05:39.353 2864     File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 473, in _run_single_test
02:05:39.353 2864       self._name, driver, test_input, stop_when_done)
02:05:39.353 2864     File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 47, in run_single_test
02:05:39.353 2864       return runner.run()
02:05:39.353 2864     File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 106, in run
02:05:39.353 2864       return self._run_compare_test()
02:05:39.353 2864     File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 122, in _run_compare_test
02:05:39.353 2864       test_result = self._compare_output(expected_driver_output, driver_output)
02:05:39.353 2864     File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 230, in _compare_output
02:05:39.353 2864       failures.extend(self._compare_text(expected_driver_output.text, driver_output.text))
02:05:39.353 2864     File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 238, in _compare_text
02:05:39.353 2864       if self._options.ignore_render_tree_dump_results and self._render_tree_dump_pattern.match(actual_text):

[Truitt Savell]

After this rollout Windows testing is working again https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Tests%29/builds/5546

[Antti Koivisto]

Created attachment 409464 [details]
patch

[Antti Koivisto]

The failures were because some tests produce null actual_text

[EWS]

Committed r267517: <https://trac.webkit.org/changeset/267517>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409464 [details].