RESOLVED FIXED 209897
[Windows] Ignore render tree dump based results on Windows
https://bugs.webkit.org/show_bug.cgi?id=209897
Summary [Windows] Ignore render tree dump based results on Windows
Antti Koivisto
Reported 2020-04-02 01:51:54 PDT
Render tree dumps are port specific and so difficult to maintain. They are mostly very old and have been superseded by more modern ref and text dump tests. They rarely reveal any port specific bugs.
Attachments
patch (3.48 KB, patch)
2020-04-02 01:59 PDT, Antti Koivisto
no flags
patch (3.49 KB, patch)
2020-04-02 02:07 PDT, Antti Koivisto
no flags
patch (3.51 KB, patch)
2020-09-23 05:28 PDT, Antti Koivisto
no flags
Antti Koivisto
Comment 1 2020-04-02 01:59:48 PDT
Antti Koivisto
Comment 2 2020-04-02 02:07:43 PDT
EWS
Comment 3 2020-04-03 00:08:47 PDT
Committed r259446: <https://trac.webkit.org/changeset/259446> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395252 [details].
Radar WebKit Bug Importer
Comment 4 2020-04-03 00:09:17 PDT
Truitt Savell
Comment 5 2020-04-07 13:23:56 PDT
Reverted r259446 for reason: Broke Windows testing Committed r259667: <https://trac.webkit.org/changeset/259667>
Ryan Haddad
Comment 6 2020-04-07 13:26:24 PDT
Example of failure: https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Tests%29/builds/5456 02:05:39.348 2864 worker/2: TypeError('expected string or buffer') raised: 02:05:39.352 2864 File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/common/message_pool.py", line 280, in run 02:05:39.352 2864 worker.handle(message.name, message.src, *message.args) 02:05:39.352 2864 File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 291, in handle 02:05:39.352 2864 self._run_test(test_input, test_list_name) 02:05:39.352 2864 File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 317, in _run_test 02:05:39.352 2864 result = self._run_test_with_or_without_timeout(test_input, test_timeout_sec, stop_when_done) 02:05:39.352 2864 File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 383, in _run_test_with_or_without_timeout 02:05:39.352 2864 return self._run_test_in_this_thread(test_input, stop_when_done) 02:05:39.353 2864 File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 469, in _run_test_in_this_thread 02:05:39.353 2864 return self._run_single_test(self._driver, test_input, stop_when_done) 02:05:39.353 2864 File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 473, in _run_single_test 02:05:39.353 2864 self._name, driver, test_input, stop_when_done) 02:05:39.353 2864 File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 47, in run_single_test 02:05:39.353 2864 return runner.run() 02:05:39.353 2864 File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 106, in run 02:05:39.353 2864 return self._run_compare_test() 02:05:39.353 2864 File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 122, in _run_compare_test 02:05:39.353 2864 test_result = self._compare_output(expected_driver_output, driver_output) 02:05:39.353 2864 File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 230, in _compare_output 02:05:39.353 2864 failures.extend(self._compare_text(expected_driver_output.text, driver_output.text)) 02:05:39.353 2864 File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 238, in _compare_text 02:05:39.353 2864 if self._options.ignore_render_tree_dump_results and self._render_tree_dump_pattern.match(actual_text):
Truitt Savell
Comment 7 2020-04-07 14:27:37 PDT
Antti Koivisto
Comment 8 2020-09-23 05:28:45 PDT
Antti Koivisto
Comment 9 2020-09-23 05:29:28 PDT
The failures were because some tests produce null actual_text
EWS
Comment 10 2020-09-23 21:33:28 PDT
Committed r267517: <https://trac.webkit.org/changeset/267517> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409464 [details].
Note You need to log in before you can comment on or make changes to this bug.