Bug 209894 - HTMLFormElement should use WeakPtr to keep track of its associated elements
Summary: HTMLFormElement should use WeakPtr to keep track of its associated elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-01 22:08 PDT by Ryosuke Niwa
Modified: 2020-04-02 11:08 PDT (History)
11 users (show)

See Also:

Attachments
Uses WeakPtr (22.62 KB, patch)
2020-04-01 22:19 PDT, Ryosuke Niwa 		wenson_hsieh: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2020-04-01 22:08:23 PDT 
HTMLFormElement currently has raw pointers to FormAssociatedElement. Replace them with WeakPtr.
Comment 1 Ryosuke Niwa 2020-04-01 22:19:50 PDT 
Created attachment 395244 [details]
Uses WeakPtr
Comment 2 Ryosuke Niwa 2020-04-02 09:50:23 PDT 
Ping reviewers.
Comment 3 Wenson Hsieh 2020-04-02 09:55:44 PDT 
Comment on attachment 395244 [details]
Uses WeakPtr

View in context: https://bugs.webkit.org/attachment.cgi?id=395244&action=review

> Source/WebCore/html/HTMLFormElement.cpp:890
> +        

Nit - extra newline here.
Comment 4 Ryosuke Niwa 2020-04-02 11:04:14 PDT 
Committed r259393: <https://trac.webkit.org/changeset/259393>
Comment 5 Radar WebKit Bug Importer 2020-04-02 11:05:16 PDT 
<rdar://problem/61216706>
Comment 6 Ryosuke Niwa 2020-04-02 11:07:29 PDT 
(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 395244 [details]
> Uses WeakPtr
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=395244&action=review
> 
> > Source/WebCore/html/HTMLFormElement.cpp:890
> > +        
> 
> Nit - extra newline here.

Oh oops, I missed that.
Comment 7 Ryosuke Niwa 2020-04-02 11:08:22 PDT 
Fixed that in https://trac.webkit.org/changeset/259394