Bug 209893 – Add SPI to restrict loading to main resources or non-network loads

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Add SPI to restrict loading to main resources or non-network loads

[Alex Christensen]

Created attachment 395242 [details]
Patch

[Tim Horton]

Comment on attachment 395242 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395242&action=review

Seems reasonable to me though I'd love a cdumez or bradee-oh review

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:921
> +- (BOOL)_loadsFromNetwork

Is this a good name? It really means "allowsLoadingFromHTTPFamilySchemes", right? (what about web sockets, WKURLSchemeHandlers that happen to hit the network, etc...)

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:931
> +- (BOOL)_loadsSubresources

Are we consistent in this capitalization of subresources?

[Alex Christensen]

Created attachment 395243 [details]
Patch

[Alex Christensen]

_loadsFromNetwork prevents http, https, ws, and wss loads.  This is to fix rdar://problem/19426383 which was fixed using bundle SPI that did not block web sockets.  This does block web sockets, as verified by the test, which counts the number of requests.  If it did not block web sockets, the server would see a "request" from the web socket.
We are quite consistent in our capitalization of Subresources.

[Tim Horton]

Ah, I see the WebSocket change now.

[EWS]

Committed r259392: <https://trac.webkit.org/changeset/259392>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395243 [details].

[Radar WebKit Bug Importer]

<rdar://problem/61215964>