Bug 209877 - Web Inspector: focus outline of scope bar is clipped
Summary: Web Inspector: focus outline of scope bar is clipped
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-01 13:52 PDT by Nikita Vasilyev
Modified: 2020-04-07 13:18 PDT (History)
3 users (show)

See Also:


Attachments
[Image] Bug (8.75 KB, image/png)
2020-04-01 13:52 PDT, Nikita Vasilyev
no flags Details
Patch (1.07 KB, patch)
2020-04-01 13:59 PDT, Nikita Vasilyev
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2020-04-01 13:52:52 PDT
Created attachment 395198 [details]
[Image] Bug

Affected areas:

In Sources tab, left sidebar: "By Type" and "By Path".
Storage tab, left sidebar: "All Storage" and "Application Cache"
Comment 1 Radar WebKit Bug Importer 2020-04-01 13:53:03 PDT
<rdar://problem/61173598>
Comment 2 Nikita Vasilyev 2020-04-01 13:59:02 PDT
Created attachment 395200 [details]
Patch
Comment 3 Timothy Hatcher 2020-04-02 16:07:05 PDT
Comment on attachment 395200 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395200&action=review

> Source/WebInspectorUI/UserInterface/Views/ScopeBar.css:-28
> -    overflow: hidden;

Do we know why overflow: hidden was here to begin with? Was it to prevent bad overflow when there is not enough room?
Comment 4 Nikita Vasilyev 2020-04-02 16:44:04 PDT
Comment on attachment 395200 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395200&action=review

>> Source/WebInspectorUI/UserInterface/Views/ScopeBar.css:-28
>> -    overflow: hidden;
> 
> Do we know why overflow: hidden was here to begin with? Was it to prevent bad overflow when there is not enough room?

I looked at all cases where the scope bar is used (`new WI.ScopeBar`) and haven't found any issues with removing `overflow: hidden`.
Comment 5 Nikita Vasilyev 2020-04-02 16:47:33 PDT
Comment on attachment 395200 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395200&action=review

>>> Source/WebInspectorUI/UserInterface/Views/ScopeBar.css:-28
>>> -    overflow: hidden;
>> 
>> Do we know why overflow: hidden was here to begin with? Was it to prevent bad overflow when there is not enough room?
> 
> I looked at all cases where the scope bar is used (`new WI.ScopeBar`) and haven't found any issues with removing `overflow: hidden`.

To answer your 1st question, I don't know why `overflow: hidden` is here. `git blame` shows that this line was added in 2013 when Web Inspector was open sourced again.
Comment 6 EWS 2020-04-07 13:17:59 PDT
Committed r259666: <https://trac.webkit.org/changeset/259666>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395200 [details].