Bug 209868 – Context menu for local storage puts quotes around key and value

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Jon Lee]

In the LocalStorage table, right clicking on a cell shows a context menu that either says

Edit "Key"
Edit "Value"

based on the cell column.

Using quotes is weird because it's not the name of the key, and unnecessary. Typically it would just say

Edit Key
Edit Value

[Devin Rousso]

Created attachment 395193 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 395193 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395193&action=review

rs=me

> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:454
>  localizedStrings["Edit \u201C%s\u201D"] = "Edit \u201C%s\u201D";

Seems this string is still used somewhere. Does its case still make sense?

[Devin Rousso]

Comment on attachment 395193 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395193&action=review

>> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:454
>>  localizedStrings["Edit \u201C%s\u201D"] = "Edit \u201C%s\u201D";
> 
> Seems this string is still used somewhere. Does its case still make sense?

Actually, it isn't 😅 I had an out-of-date localizedStrings.js.

[Devin Rousso]

Created attachment 395325 [details]
Patch

[EWS]

Committed r259437: <https://trac.webkit.org/changeset/259437>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395325 [details].

[Radar WebKit Bug Importer]

<rdar://problem/61236498>