Bug 209868 - Context menu for local storage puts quotes around key and value
Summary: Context menu for local storage puts quotes around key and value
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: Safari 13
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-01 11:21 PDT by Jon Lee
Modified: 2020-04-02 18:25 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.80 KB, patch)
2020-04-01 12:58 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (3.10 KB, patch)
2020-04-02 16:57 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2020-04-01 11:21:27 PDT
In the LocalStorage table, right clicking on a cell shows a context menu that either says

Edit "Key"
Edit "Value"

based on the cell column.

Using quotes is weird because it's not the name of the key, and unnecessary. Typically it would just say

Edit Key
Edit Value
Comment 1 Devin Rousso 2020-04-01 12:58:14 PDT
Created attachment 395193 [details]
Patch
Comment 2 Joseph Pecoraro 2020-04-01 13:07:30 PDT
Comment on attachment 395193 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395193&action=review

rs=me

> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:454
>  localizedStrings["Edit \u201C%s\u201D"] = "Edit \u201C%s\u201D";

Seems this string is still used somewhere. Does its case still make sense?
Comment 3 Devin Rousso 2020-04-02 16:56:21 PDT
Comment on attachment 395193 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395193&action=review

>> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:454
>>  localizedStrings["Edit \u201C%s\u201D"] = "Edit \u201C%s\u201D";
> 
> Seems this string is still used somewhere. Does its case still make sense?

Actually, it isn't 😅 I had an out-of-date localizedStrings.js.
Comment 4 Devin Rousso 2020-04-02 16:57:09 PDT
Created attachment 395325 [details]
Patch
Comment 5 EWS 2020-04-02 18:24:53 PDT
Committed r259437: <https://trac.webkit.org/changeset/259437>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395325 [details].
Comment 6 Radar WebKit Bug Importer 2020-04-02 18:25:15 PDT
<rdar://problem/61236498>