Bug 209867 – Web Inspector: Storage: cannot clear out multiple or all local storage entries

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Jon Lee]

I'd like to be able to delete multiple key/values pairs in local storage in WI.

This breaks down to a few requests:
- Allow selection of multiple rows
- Command-A to select all rows
- A button to clear all local storage
- Right click on "Local Storage" in the left sidebar with option to "Clear All Items"

[Jon Lee]

Also, if I select a row, and then press delete, it doesn't by default select the next row. So I can't mash the delete key to remove a series of key/value pairs, either.

[Jon Lee]

A good place to test this is to load

https://browserbench.org/MotionMark/developer.html

and press "Run benchmark". That will set entries.

[Devin Rousso]

(In reply to Jon Lee from comment #0)
> - Allow selection of multiple rows
> - Command-A to select all rows
These both should be solved if we switch from `WI.DataGrid` to `WI.Table`.  We'd need to either add logic to `WI.Table` to support editing by default, or add custom logic to `WI.DOMStorageContentView` for editing.

> - A button to clear all local storage
> - Right click on "Local Storage" in the left sidebar with option to "Clear All Items"
We could do this with a new protocol command (i.e. `DOMStorage.clearDOMStorageItems` like `IndexedDB.clearObjectStore`), but we could also do this by successively calling `DOMStorage.removeDOMStorageItem` with each item.  This would be a lot of protocol traffic, but it would be backwards compatible.

We may want to extend many of these to `IndexedDB` as well :)

[Devin Rousso]

Created attachment 395542 [details]
Patch

[EWS Watchlist]

This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.

[EWS]

Committed r259744: <https://trac.webkit.org/changeset/259744>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395542 [details].

[Radar WebKit Bug Importer]

<rdar://problem/61469103>

[Jon Lee]

(In reply to Devin Rousso from comment #3)
> (In reply to Jon Lee from comment #0)
> > - Allow selection of multiple rows
> > - Command-A to select all rows
> These both should be solved if we switch from `WI.DataGrid` to `WI.Table`. 
> We'd need to either add logic to `WI.Table` to support editing by default,
> or add custom logic to `WI.DOMStorageContentView` for editing.

These still haven't been addressed. Will split off another bug and relate.