Bug 209857 – Add HEVC support in GPU Process for WebRTC

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Add HEVC support in GPU Process for WebRTC

[youenn fablet]

Created attachment 395168 [details]
Patch

[youenn fablet]

Created attachment 395175 [details]
Patch

[youenn fablet]

Created attachment 395367 [details]
Patch

[EWS]

ChangeLog entry in Source/ThirdParty/libwebrtc/ChangeLog contains OOPS!.

[Eric Carlson]

Comment on attachment 395367 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395367&action=review

> Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.mm:153
> +    supported_formats.push_back(SdpVideoFormat { "H264" });
> +    supported_formats.push_back(SdpVideoFormat { "VP8" });

Should this add "H265" as well?

[youenn fablet]

(In reply to Eric Carlson from comment #5)
> Comment on attachment 395367 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=395367&action=review
> 
> > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.mm:153
> > +    supported_formats.push_back(SdpVideoFormat { "H264" });
> > +    supported_formats.push_back(SdpVideoFormat { "VP8" });
> 
> Should this add "H265" as well?

Thanks, will fix it.
Looking at libwebrtc code, I do not really see where it is used on the decoder side (it is used on the encoder side though).

[youenn fablet]

Created attachment 395551 [details]
Patch for landing

[EWS]

Found 1 new test failure: storage/indexeddb/value-cursor-cycle.html

[EWS]

Committed r259568: <https://trac.webkit.org/changeset/259568>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395551 [details].

[Radar WebKit Bug Importer]

<rdar://problem/61335983>