Bug 209857 - Add HEVC support in GPU Process for WebRTC
Summary: Add HEVC support in GPU Process for WebRTC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-01 08:11 PDT by youenn fablet
Modified: 2020-04-06 02:58 PDT (History)
9 users (show)

See Also:

Attachments
Patch (239.42 KB, patch)
2020-04-01 08:13 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (240.48 KB, patch)
2020-04-01 09:23 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (67.40 KB, patch)
2020-04-03 05:31 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (67.51 KB, patch)
2020-04-06 00:11 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-04-01 08:11:03 PDT 
Add HEVC support in GPU Process for WebRTC
Comment 1 youenn fablet 2020-04-01 08:13:33 PDT 
Created attachment 395168 [details]
Patch
Comment 2 youenn fablet 2020-04-01 09:23:51 PDT 
Created attachment 395175 [details]
Patch
Comment 3 youenn fablet 2020-04-03 05:31:44 PDT 
Created attachment 395367 [details]
Patch
Comment 4 EWS 2020-04-03 07:34:23 PDT 
ChangeLog entry in Source/ThirdParty/libwebrtc/ChangeLog contains OOPS!.
Comment 5 Eric Carlson 2020-04-03 12:21:49 PDT 
Comment on attachment 395367 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395367&action=review

> Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.mm:153
> +    supported_formats.push_back(SdpVideoFormat { "H264" });
> +    supported_formats.push_back(SdpVideoFormat { "VP8" });

Should this add "H265" as well?
Comment 6 youenn fablet 2020-04-06 00:10:57 PDT 
(In reply to Eric Carlson from comment #5)
> Comment on attachment 395367 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=395367&action=review
> 
> > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoder.mm:153
> > +    supported_formats.push_back(SdpVideoFormat { "H264" });
> > +    supported_formats.push_back(SdpVideoFormat { "VP8" });
> 
> Should this add "H265" as well?

Thanks, will fix it.
Looking at libwebrtc code, I do not really see where it is used on the decoder side (it is used on the encoder side though).
Comment 7 youenn fablet 2020-04-06 00:11:28 PDT 
Created attachment 395551 [details]
Patch for landing
Comment 8 EWS 2020-04-06 02:04:50 PDT 
Found 1 new test failure: storage/indexeddb/value-cursor-cycle.html
Comment 9 EWS 2020-04-06 02:57:32 PDT 
Committed r259568: <https://trac.webkit.org/changeset/259568>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395551 [details].
Comment 10 Radar WebKit Bug Importer 2020-04-06 02:58:14 PDT 
<rdar://problem/61335983>