Bug 209844 - TestOptions::enableUndoManagerAPI can be removed
Summary: TestOptions::enableUndoManagerAPI can be removed
Status: RESOLVED DUPLICATE of bug 209678
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-31 18:46 PDT by David Kilzer (:ddkilzer)
Modified: 2020-03-31 20:21 PDT (History)
1 user (show)

See Also:

Attachments
Patch v1 (9.35 KB, patch)
2020-03-31 18:48 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2020-03-31 18:46:23 PDT 
TestOptions::enableUndoManagerAPI can be removed because using "internal:UndoManagerAPIEnabled" will just work:

-<!DOCTYPE html> <!-- webkit-test-runner [ enableUndoManagerAPI=true ] -->
+<!DOCTYPE html> <!-- webkit-test-runner [ internal:UndoManagerAPIEnabled=true ] -->
Comment 1 David Kilzer (:ddkilzer) 2020-03-31 18:48:57 PDT 
Created attachment 395120 [details]
Patch v1
Comment 2 David Kilzer (:ddkilzer) 2020-03-31 19:05:17 PDT 
Comment on attachment 395120 [details]
Patch v1

Hmmm, I may have underestimated what the fix in Bug 209678 does.  Testing locally, this actually doesn't work by itself.  I cleared the review flag for now.
Comment 3 David Kilzer (:ddkilzer) 2020-03-31 20:21:00 PDT 
Welp, it turns out this depends on changes in Bug 209678, so duping to that.

*** This bug has been marked as a duplicate of bug 209678 ***