WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
209840
Dismiss color picker on color selection on MacCatalyst
https://bugs.webkit.org/show_bug.cgi?id=209840
Summary
Dismiss color picker on color selection on MacCatalyst
Megan Gardner
Reported
2020-03-31 17:10:10 PDT
Dismiss color picker on color selection on MacCatalyst
Attachments
Patch
(4.21 KB, patch)
2020-03-31 17:15 PDT
,
Megan Gardner
no flags
Details
Formatted Diff
Diff
Patch
(4.22 KB, patch)
2020-03-31 17:44 PDT
,
Megan Gardner
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Megan Gardner
Comment 1
2020-03-31 17:15:37 PDT
Created
attachment 395110
[details]
Patch
Megan Gardner
Comment 2
2020-03-31 17:16:12 PDT
<
rdar://problem/46793808
>
Darin Adler
Comment 3
2020-03-31 17:23:28 PDT
Comment on
attachment 395110
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=395110&action=review
> Source/WebKit/UIProcess/ios/forms/WKFormColorPicker.mm:154 > + WKColorPopover *_popover;
What makes it safe to keep this pointer without RetainPtr or WeakObjCPtr?
Megan Gardner
Comment 4
2020-03-31 17:44:52 PDT
Created
attachment 395113
[details]
Patch
EWS
Comment 5
2020-03-31 20:19:49 PDT
Committed
r259336
: <
https://trac.webkit.org/changeset/259336
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 395113
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug