Bug 209840 - Dismiss color picker on color selection on MacCatalyst
Summary: Dismiss color picker on color selection on MacCatalyst
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-31 17:10 PDT by Megan Gardner
Modified: 2020-03-31 20:19 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.21 KB, patch)
2020-03-31 17:15 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch (4.22 KB, patch)
2020-03-31 17:44 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2020-03-31 17:10:10 PDT 
Dismiss color picker on color selection on MacCatalyst
Comment 1 Megan Gardner 2020-03-31 17:15:37 PDT 
Created attachment 395110 [details]
Patch
Comment 2 Megan Gardner 2020-03-31 17:16:12 PDT 
<rdar://problem/46793808>
Comment 3 Darin Adler 2020-03-31 17:23:28 PDT 
Comment on attachment 395110 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395110&action=review

> Source/WebKit/UIProcess/ios/forms/WKFormColorPicker.mm:154
> +    WKColorPopover *_popover;

What makes it safe to keep this pointer without RetainPtr or WeakObjCPtr?
Comment 4 Megan Gardner 2020-03-31 17:44:52 PDT 
Created attachment 395113 [details]
Patch
Comment 5 EWS 2020-03-31 20:19:49 PDT 
Committed r259336: <https://trac.webkit.org/changeset/259336>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395113 [details].