Bug 209826 - Make FrameView and Frame TextStream-loggable
Summary: Make FrameView and Frame TextStream-loggable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-31 12:25 PDT by Simon Fraser (smfr)
Modified: 2020-03-31 19:50 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.15 KB, patch)
2020-03-31 12:26 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-03-31 12:25:18 PDT
Make FrameView and Frame TextStream-loggable
Comment 1 Simon Fraser (smfr) 2020-03-31 12:26:29 PDT
Created attachment 395078 [details]
Patch
Comment 2 Darin Adler 2020-03-31 12:34:53 PDT
Comment on attachment 395078 [details]
Patch

I totally want to reverse the ValueOrNull thing for TextStream. By default pointers should log "value of pointed to thing or null" and we should have a function you can call on a pointer to make it instead log a hex pointer value.

Also, if we keep ValueOrNull we can leave off the "OrNull" part. The real question is whether to log the pointer or the pointed-to thing. Not sure the word "value" is unambiguous about that, but it’s cool.
Comment 3 EWS 2020-03-31 19:49:38 PDT
Committed r259335: <https://trac.webkit.org/changeset/259335>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395078 [details].
Comment 4 Radar WebKit Bug Importer 2020-03-31 19:50:15 PDT
<rdar://problem/61137062>