Bug 209814 – [macOS] Deny mach-lookup access to "com.apple.lsd.mapdb" in sandbox

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Per Arne Vollan]

The WebContent sandbox should deny mach-lookup access to "com.apple.lsd.mapdb" on macOS.

[Per Arne Vollan]

Created attachment 395048 [details]
Patch

[Per Arne Vollan]

Created attachment 395060 [details]
Patch

[Per Arne Vollan]

Created attachment 395079 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/61119618>

[Darin Adler]

Comment on attachment 395079 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395079&action=review

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:276
> +    // Map Launch Services database

WebKit coding style asks for a "." here.

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:360
> +#if HAVE(CSCHECKFIXDISABLE)
> +            // _CSCheckFixDisable() needs to be called before checking in with Launch Services.
> +            _CSCheckFixDisable();
> +#endif

Why does’t this belong inside the launchServicesCheckIn function?

[Per Arne Vollan]

Created attachment 395080 [details]
Patch

[Per Arne Vollan]

(In reply to Darin Adler from comment #5)
> Comment on attachment 395079 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=395079&action=review
> 
> > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:276
> > +    // Map Launch Services database
> 
> WebKit coding style asks for a "." here.
> 

Will fix.

> > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:360
> > +#if HAVE(CSCHECKFIXDISABLE)
> > +            // _CSCheckFixDisable() needs to be called before checking in with Launch Services.
> > +            _CSCheckFixDisable();
> > +#endif
> 
> Why does’t this belong inside the launchServicesCheckIn function?

That is a very good point. This would mean all other WebKit processes would get this, but I think that is only a good thing. I will update the patch.

Thanks for reviewing!

[Per Arne Vollan]

Created attachment 395084 [details]
Patch

[EWS]

Committed r259328: <https://trac.webkit.org/changeset/259328>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395084 [details].

[WebKit Commit Bot]

Re-opened since this is blocked by bug 209861

[Per Arne Vollan]

Created attachment 395207 [details]
Patch

[EWS]

Committed r259366: <https://trac.webkit.org/changeset/259366>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395207 [details].